All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/9] clocksource/cadence_ttc: Store timer frequency in driver data
Date: Wed, 18 Dec 2013 15:53:51 +0100	[thread overview]
Message-ID: <52B1B6FF.7000400@linaro.org> (raw)
In-Reply-To: <5cff3201-db97-4061-a686-bf79ac17d4fe@CO1EHSMHS006.ehs.local>

On 12/17/2013 08:21 PM, S?ren Brinkmann wrote:
> Hi Daniel,
>
> On Tue, Nov 26, 2013 at 05:04:50PM -0800, Soren Brinkmann wrote:
>> It is not allowed to call clk_get_rate() from interrupt context. To
>> avoid such calls the timer input frequency is stored in the driver's
>> data struct which makes it accessible to the driver in any context.
>>
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> I doubt that we'll resolve all issues with this series before the
> holidays or even the next merge window. Could you take this patch into
> your tree for 3.14? It is not directly related to the cpufreq work and
> fixes an actual issue that triggers a kernel WARN under some condition
> (I missed preserving the details and the trace). That would take the
> easy stuff out of the way and we can focus on the more controversial
> changes.

You are asking to take it for 3.14 but shouldn't it go as a 3.13 fix ?

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: "Sören Brinkmann"
	<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	"Michal Simek"
	<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2 3/9] clocksource/cadence_ttc: Store timer frequency in driver data
Date: Wed, 18 Dec 2013 15:53:51 +0100	[thread overview]
Message-ID: <52B1B6FF.7000400@linaro.org> (raw)
In-Reply-To: <5cff3201-db97-4061-a686-bf79ac17d4fe-W/Q257+MkyH5op9OF0Koj7jjLBE8jN/0@public.gmane.org>

On 12/17/2013 08:21 PM, Sören Brinkmann wrote:
> Hi Daniel,
>
> On Tue, Nov 26, 2013 at 05:04:50PM -0800, Soren Brinkmann wrote:
>> It is not allowed to call clk_get_rate() from interrupt context. To
>> avoid such calls the timer input frequency is stored in the driver's
>> data struct which makes it accessible to the driver in any context.
>>
>> Signed-off-by: Soren Brinkmann <soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
>> Acked-by: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> I doubt that we'll resolve all issues with this series before the
> holidays or even the next merge window. Could you take this patch into
> your tree for 3.14? It is not directly related to the cpufreq work and
> fixes an actual issue that triggers a kernel WARN under some condition
> (I missed preserving the details and the trace). That would take the
> easy stuff out of the way and we can focus on the more controversial
> changes.

You are asking to take it for 3.14 but shouldn't it go as a 3.13 fix ?

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Thomas Gleixner" <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2 3/9] clocksource/cadence_ttc: Store timer frequency in driver data
Date: Wed, 18 Dec 2013 15:53:51 +0100	[thread overview]
Message-ID: <52B1B6FF.7000400@linaro.org> (raw)
In-Reply-To: <5cff3201-db97-4061-a686-bf79ac17d4fe@CO1EHSMHS006.ehs.local>

On 12/17/2013 08:21 PM, Sören Brinkmann wrote:
> Hi Daniel,
>
> On Tue, Nov 26, 2013 at 05:04:50PM -0800, Soren Brinkmann wrote:
>> It is not allowed to call clk_get_rate() from interrupt context. To
>> avoid such calls the timer input frequency is stored in the driver's
>> data struct which makes it accessible to the driver in any context.
>>
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> I doubt that we'll resolve all issues with this series before the
> holidays or even the next merge window. Could you take this patch into
> your tree for 3.14? It is not directly related to the cpufreq work and
> fixes an actual issue that triggers a kernel WARN under some condition
> (I missed preserving the details and the trace). That would take the
> easy stuff out of the way and we can focus on the more controversial
> changes.

You are asking to take it for 3.14 but shouldn't it go as a 3.13 fix ?

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  reply	other threads:[~2013-12-18 14:53 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  1:04 [PATCH v2 0/9] arm: zynq: Add support for cpufreq Soren Brinkmann
2013-11-27  1:04 ` Soren Brinkmann
2013-11-27  1:04 ` Soren Brinkmann
2013-11-27  1:04 ` [PATCH v2 1/9] arm: dt: zynq: Remove 'clock-ranges' from TTC nodes Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-12-12  8:53   ` Michal Simek
2013-12-12  8:53     ` Michal Simek
2013-12-12 17:01     ` Sören Brinkmann
2013-12-12 17:01       ` Sören Brinkmann
2013-12-12 17:01       ` Sören Brinkmann
2013-12-12 19:07       ` Michal Simek
2013-12-12 19:07         ` Michal Simek
2013-11-27  1:04 ` [PATCH v2 2/9] arm: dt: zynq: Add 'cpus' node Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-11-27  1:04 ` [PATCH v2 3/9] clocksource/cadence_ttc: Store timer frequency in driver data Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-12-17 19:21   ` Sören Brinkmann
2013-12-17 19:21     ` Sören Brinkmann
2013-12-17 19:21     ` Sören Brinkmann
2013-12-18 14:53     ` Daniel Lezcano [this message]
2013-12-18 14:53       ` Daniel Lezcano
2013-12-18 14:53       ` Daniel Lezcano
2013-12-18 16:47       ` Sören Brinkmann
2013-12-18 16:47         ` Sören Brinkmann
2013-12-18 16:47         ` Sören Brinkmann
2013-12-18 21:58         ` Daniel Lezcano
2013-12-18 21:58           ` Daniel Lezcano
2013-12-19 18:32           ` Sören Brinkmann
2013-12-19 18:32             ` Sören Brinkmann
2013-12-19 18:32             ` Sören Brinkmann
2013-12-19 20:53             ` Daniel Lezcano
2013-12-19 20:53               ` Daniel Lezcano
2013-12-19 21:23               ` Sören Brinkmann
2013-12-19 21:23                 ` Sören Brinkmann
2013-12-19 21:23                 ` Sören Brinkmann
2013-12-19 21:39                 ` Daniel Lezcano
2013-12-19 21:39                   ` Daniel Lezcano
2013-12-19 21:39                   ` Daniel Lezcano
2013-11-27  1:04 ` [PATCH v2 4/9] clocksource/cadence_ttc: Use enable/disable_irq Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-11-28 11:55   ` Daniel Lezcano
2013-11-28 11:55     ` Daniel Lezcano
2013-11-28 11:55     ` Daniel Lezcano
2013-11-28 14:18     ` Thomas Gleixner
2013-11-28 14:18       ` Thomas Gleixner
2013-11-28 14:18       ` Thomas Gleixner
2013-11-28 18:36       ` Sören Brinkmann
2013-11-28 18:36         ` Sören Brinkmann
2013-11-28 18:36         ` Sören Brinkmann
2013-11-28 19:07         ` Thomas Gleixner
2013-11-28 19:07           ` Thomas Gleixner
2013-11-28 19:07           ` Thomas Gleixner
2013-12-06 22:47           ` Sören Brinkmann
2013-12-06 22:47             ` Sören Brinkmann
2013-12-06 22:47             ` Sören Brinkmann
2013-12-07 10:56             ` Thomas Gleixner
2013-12-07 10:56               ` Thomas Gleixner
2013-12-07 10:56               ` Thomas Gleixner
2013-12-10  0:34               ` [PATCH 0/2] clockevents Soren Brinkmann
2013-12-10  0:34                 ` Soren Brinkmann
2013-12-10  0:34                 ` [PATCH 1/2] time: Serialize calls to 'clockevents_update_freq' in the timing core Soren Brinkmann
2013-12-10  0:34                   ` Soren Brinkmann
2013-12-11 14:32                   ` Daniel Lezcano
2013-12-11 14:32                     ` Daniel Lezcano
2013-12-11 14:32                     ` Daniel Lezcano
2013-12-11 20:09                     ` Sören Brinkmann
2013-12-11 20:09                       ` Sören Brinkmann
2013-12-11 20:09                       ` Sören Brinkmann
2013-12-12 12:07                       ` Daniel Lezcano
2013-12-12 12:07                         ` Daniel Lezcano
2013-12-12 12:07                         ` Daniel Lezcano
2013-12-10  0:34                 ` [PATCH 2/2] time: clockevents: Adjust timer interval when frequency changes Soren Brinkmann
2013-12-10  0:34                   ` Soren Brinkmann
2013-11-27  1:04 ` [PATCH v2 5/9] clocksource/cadence_ttc: Adjust interval in clock notifier Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-12-12 12:15   ` Daniel Lezcano
2013-12-12 12:15     ` Daniel Lezcano
2013-12-12 12:15     ` Daniel Lezcano
2013-12-12 18:44     ` Sören Brinkmann
2013-12-12 18:44       ` Sören Brinkmann
2013-12-12 18:44       ` Sören Brinkmann
2013-11-27  1:04 ` [PATCH v2 6/9] clocksource/cadence_ttc: Overhaul clocksource frequency adjustment Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-11-27  1:04 ` [PATCH v2 7/9] clocksource/cadence_ttc: Use only one counter Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-11-27  1:04 ` [PATCH v2 8/9] arm: zynq: Don't use arm_global_timer with cpufreq Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann
2013-11-27  1:04 ` [PATCH v2 9/9] arm: zynq: Add support for cpufreq Soren Brinkmann
2013-11-27  1:04   ` Soren Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B1B6FF.7000400@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.