From: Paolo Bonzini <pbonzini@redhat.com>
To: Gal Hammer <ghammer@redhat.com>
Cc: "seabios@seabios.org" <seabios@seabios.org>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset.
Date: Wed, 18 Dec 2013 17:00:04 +0100 [thread overview]
Message-ID: <52B1C684.5020803@redhat.com> (raw)
In-Reply-To: <52B1C654.2070308@redhat.com>
Il 18/12/2013 16:59, Gal Hammer ha scritto:
>>
>> Note this is not the APIC base address, that one is 80h on the ISA
>> bridge (function 0). You're changing the behavior for 80h on the power
>> management function, which is function 3. The register is "PMBA—POWER
>> MANAGEMENT BASE ADDRESS" and it is indeed initialized by SeaBIOS in
>> piix4_pm_setup (src/fw/pciinit.c).
>
> I think we both made a mistake and the right name is
> "PMREGMISC—MISCELLANEOUS POWER MANAGEMENT (FUNCTION 3)" :-).
Yeah. :) Still, both PMBA and PMREGMISC need to be initialized by SeaBIOS.
Paolo
prev parent reply other threads:[~2013-12-18 16:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 9:21 [Qemu-devel] [PATCH] piix: do not reset APIC base address (0x80) on piix4_reset Gal Hammer
2013-12-11 10:23 ` Paolo Bonzini
2013-12-11 10:44 ` Michael S. Tsirkin
2013-12-11 11:04 ` Gal Hammer
2013-12-18 14:19 ` Paolo Bonzini
2013-12-18 15:16 ` Gal Hammer
2013-12-18 21:57 ` Laszlo Ersek
2013-12-18 14:22 ` Paolo Bonzini
2013-12-18 15:22 ` Michael S. Tsirkin
2013-12-18 16:27 ` Marcel Apfelbaum
2013-12-18 16:33 ` Michael S. Tsirkin
2013-12-18 16:34 ` Paolo Bonzini
2013-12-18 16:55 ` Marcel Apfelbaum
2013-12-18 17:21 ` Michael S. Tsirkin
2013-12-19 16:06 ` Kevin O'Connor
2013-12-19 18:03 ` Marcel Apfelbaum
2013-12-19 18:17 ` Kevin O'Connor
2013-12-18 16:58 ` Michael S. Tsirkin
2013-12-18 22:10 ` Laszlo Ersek
2013-12-18 22:16 ` Laszlo Ersek
2013-12-18 23:43 ` Paolo Bonzini
2013-12-18 16:49 ` Marcel Apfelbaum
2013-12-18 17:20 ` Michael S. Tsirkin
2013-12-19 9:37 ` Marcel Apfelbaum
2013-12-19 9:49 ` Marcel Apfelbaum
2013-12-19 10:35 ` Michael S. Tsirkin
2013-12-18 15:59 ` Gal Hammer
2013-12-18 16:00 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B1C684.5020803@redhat.com \
--to=pbonzini@redhat.com \
--cc=ghammer@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.