All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qdev: Drop misleading qbus_free() function
Date: Wed, 18 Dec 2013 17:33:27 +0100	[thread overview]
Message-ID: <52B1CE57.1030705@suse.de> (raw)
In-Reply-To: <1387383351-24121-1-git-send-email-stefanha@redhat.com>

Am 18.12.2013 17:15, schrieb Stefan Hajnoczi:
> Same reasoning as commit 02a5c4c97422b40034f31265e0f139f7846172a8
> ("qdev: Drop misleading qdev_free() function").  The qbus_free()
> function removes the child from the namespace and decrements the
> reference count.  It does not, however, guarantee to free the child
> since the refcount may still be held.
> 
> Just call object_unparent() directly.
> 
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Thanks, nice and trivial, applied to qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      reply	other threads:[~2013-12-18 16:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18 16:15 [Qemu-devel] [PATCH] qdev: Drop misleading qbus_free() function Stefan Hajnoczi
2013-12-18 16:33 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B1CE57.1030705@suse.de \
    --to=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.