All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: xiaoqiang zhao <zxq_yx_007@163.com>, qemu-devel@nongnu.org
Cc: Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
	pbonzini@redhat.com,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	aliguori@amazon.com, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/4] QOM'ify apic and ioapic
Date: Wed, 18 Dec 2013 18:57:22 +0100	[thread overview]
Message-ID: <52B1E202.4070701@suse.de> (raw)
In-Reply-To: <1383646565-13774-1-git-send-email-zxq_yx_007@163.com>

Am 05.11.2013 11:16, schrieb xiaoqiang zhao:
> xiaoqiang zhao (4):
>   apic: Cleanup for QOM'ify
>   apic: QOM'ify apic & icc_bus
>   ioapic: Cleanup for QOM'ify
>   ioapic: QOM'ify ioapic

Thanks, I have rebased and queued them with changes on qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next

In particular I have reverted TYPE_ introductions were unnecessary and
reverted usages of TYPE_ constants for MemoryRegions. Also two white
lines have been dropped. The ICC bus conversion has been split out as a
separate step, using NULL errp as intermediate step since ignored.
(CC'ing Peter C. and Luiz)

However I still have doubts about the last patch and would appreciate
feedback from Paolo, Anthony or anyone, cf. upcoming reply there.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  parent reply	other threads:[~2013-12-18 17:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 10:16 [Qemu-devel] [PATCH v3 0/4] QOM'ify apic and ioapic xiaoqiang zhao
2013-11-05 10:16 ` [Qemu-devel] [PATCH v3 1/4] apic: Cleanup for QOM'ify xiaoqiang zhao
2013-11-05 10:16 ` [Qemu-devel] [PATCH v3 2/4] apic: QOM'ify apic & icc_bus xiaoqiang zhao
2013-11-05 10:16 ` [Qemu-devel] [PATCH v3 3/4] ioapic: Cleanup for QOM'ify xiaoqiang zhao
2013-11-05 10:16 ` [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic xiaoqiang zhao
2013-12-18 18:03   ` Andreas Färber
2013-12-19  2:28     ` Chen Fan
2013-12-19  2:42       ` 赵小强
2013-12-19  5:37     ` 赵小强
2013-12-19 14:20     ` Paolo Bonzini
2013-12-20 11:18       ` Andreas Färber
2013-12-20 23:02         ` <zxq_yx_007@163.com>
2013-12-18 17:57 ` Andreas Färber [this message]
2013-12-18 18:08   ` [Qemu-devel] [PATCH v3 0/4] QOM'ify apic and ioapic Andreas Färber
2013-12-18 19:20     ` Stefano Stabellini
2013-12-18 19:24       ` Andreas Färber
2013-12-18 19:29         ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B1E202.4070701@suse.de \
    --to=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=chen.fan.fnst@cn.fujitsu.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zxq_yx_007@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.