From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: xiaoqiang zhao <zxq_yx_007@163.com>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic
Date: Thu, 19 Dec 2013 15:20:24 +0100 [thread overview]
Message-ID: <52B300A8.4030903@redhat.com> (raw)
In-Reply-To: <52B1E385.4030303@suse.de>
Il 18/12/2013 19:03, Andreas Färber ha scritto:
>> > @@ -61,7 +69,6 @@ static void ioapic_common_realize(DeviceState *dev, Error **errp)
>> > {
>> > IOAPICCommonState *s = IOAPIC_COMMON(dev);
>> > IOAPICCommonClass *info;
>> > - static int ioapic_no;
>> >
>> > if (ioapic_no >= MAX_IOAPICS) {
>> > error_setg(errp, "Only %d ioapics allowed", MAX_IOAPICS);
> ... while the check for max. IOAPICs still happens in common code.
>
> Do we need to count KVM IOAPICs as well? Or can we consolidate this into
> the non-KVM version and keep it static there?
KVM only supports one IOAPIC. Creating a second fails with EEXIST.
Paolo
next prev parent reply other threads:[~2013-12-19 14:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 10:16 [Qemu-devel] [PATCH v3 0/4] QOM'ify apic and ioapic xiaoqiang zhao
2013-11-05 10:16 ` [Qemu-devel] [PATCH v3 1/4] apic: Cleanup for QOM'ify xiaoqiang zhao
2013-11-05 10:16 ` [Qemu-devel] [PATCH v3 2/4] apic: QOM'ify apic & icc_bus xiaoqiang zhao
2013-11-05 10:16 ` [Qemu-devel] [PATCH v3 3/4] ioapic: Cleanup for QOM'ify xiaoqiang zhao
2013-11-05 10:16 ` [Qemu-devel] [PATCH v3 4/4] ioapic: QOM'ify ioapic xiaoqiang zhao
2013-12-18 18:03 ` Andreas Färber
2013-12-19 2:28 ` Chen Fan
2013-12-19 2:42 ` 赵小强
2013-12-19 5:37 ` 赵小强
2013-12-19 14:20 ` Paolo Bonzini [this message]
2013-12-20 11:18 ` Andreas Färber
2013-12-20 23:02 ` <zxq_yx_007@163.com>
2013-12-18 17:57 ` [Qemu-devel] [PATCH v3 0/4] QOM'ify apic and ioapic Andreas Färber
2013-12-18 18:08 ` Andreas Färber
2013-12-18 19:20 ` Stefano Stabellini
2013-12-18 19:24 ` Andreas Färber
2013-12-18 19:29 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B300A8.4030903@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=qemu-devel@nongnu.org \
--cc=zxq_yx_007@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.