From: Sasha Levin <sasha.levin@oracle.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>, Bob Liu <lliubbo@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Linux-MM <linux-mm@kvack.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mm/rmap: fix BUG at rmap_walk
Date: Wed, 18 Dec 2013 23:59:52 -0500 [thread overview]
Message-ID: <52B27D48.9030703@oracle.com> (raw)
In-Reply-To: <20131219042902.GA27512@hacker.(null)>
On 12/18/2013 11:29 PM, Wanpeng Li wrote:
>> PageLocked is not required by page_referenced_anon() and there is not
>> >any assertion before, commit 37f093cdf introduced this extra BUG_ON()
> There are two callsites shrink_active_list and page_check_references()
> of page_referenced(). shrink_active_list and its callee won't lock anonymous
> page, however, page_check_references() is called with anonymous page
> lock held in shrink_page_list. So page_check_references case need
> specail handling.
This explanation seems to be based on current observed behaviour.
I think it would be easier if you could point out the actual code in each
function that requires a page to be locked, once we have that we don't have
to care about what the callers currently do.
Thanks,
Sasha
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sasha.levin@oracle.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>, Bob Liu <lliubbo@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Linux-MM <linux-mm@kvack.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mm/rmap: fix BUG at rmap_walk
Date: Wed, 18 Dec 2013 23:59:52 -0500 [thread overview]
Message-ID: <52B27D48.9030703@oracle.com> (raw)
In-Reply-To: <20131219042902.GA27512@hacker.(null)>
On 12/18/2013 11:29 PM, Wanpeng Li wrote:
>> PageLocked is not required by page_referenced_anon() and there is not
>> >any assertion before, commit 37f093cdf introduced this extra BUG_ON()
> There are two callsites shrink_active_list and page_check_references()
> of page_referenced(). shrink_active_list and its callee won't lock anonymous
> page, however, page_check_references() is called with anonymous page
> lock held in shrink_page_list. So page_check_references case need
> specail handling.
This explanation seems to be based on current observed behaviour.
I think it would be easier if you could point out the actual code in each
function that requires a page to be locked, once we have that we don't have
to care about what the callers currently do.
Thanks,
Sasha
next prev parent reply other threads:[~2013-12-19 5:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 3:45 [PATCH v2] mm/rmap: fix BUG at rmap_walk Wanpeng Li
2013-12-19 3:45 ` Wanpeng Li
2013-12-19 4:16 ` Bob Liu
2013-12-19 4:16 ` Bob Liu
2013-12-19 4:29 ` Wanpeng Li
[not found] ` <20131219042902.GA27512@hacker.(null)>
2013-12-19 4:59 ` Sasha Levin [this message]
2013-12-19 4:59 ` Sasha Levin
2013-12-19 5:45 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B27D48.9030703@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=lliubbo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.