From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] ARM: tegra: fix missing pincontrol configuration for Venice2
Date: Thu, 19 Dec 2013 12:44:24 +0530 [thread overview]
Message-ID: <52B29CD0.1000801@nvidia.com> (raw)
In-Reply-To: <52B20C0D.9030200-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Thursday 19 December 2013 02:26 AM, Stephen Warren wrote:
> On 12/18/2013 05:52 AM, Laxman Dewangan wrote:
>> Compare the initial population of default pinmux configuration of Venice2
>> with the chrome branch and add/fix the missing configurations.
> Wow, that's a big chunk of changes. Are you sure this is correct? Why
> was the original patch (which added the pinctrl nodes) so incorrect?
The pinmux which got added is based on the venice2 pinmux spreadsheet
where I covered only the SFIO pin groups.
https://wiki.nvidia.com/engwiki/index.php/Platform_Design_Center/Projects_Archive/PM371#pinmux
After comparing with the chrome, I also added the pinmux for all pins
which are used as GPIO and hence the change is big.
This is complete pinmux based on chrome kernel-next.
I booted chrome with this pinmux and not observe any behavioral change.
> Thierry, I thought you had mentioned comparing the pinctrl setup in
> linux-next with the downstream kernel for Venice2 and only found a
> difference in the PWM settings, which you sent a patch for. However,
> this patch is much larger than that. Where's the disconnect?
WARNING: multiple messages have this Message-ID (diff)
From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: tegra: fix missing pincontrol configuration for Venice2
Date: Thu, 19 Dec 2013 12:44:24 +0530 [thread overview]
Message-ID: <52B29CD0.1000801@nvidia.com> (raw)
In-Reply-To: <52B20C0D.9030200@wwwdotorg.org>
On Thursday 19 December 2013 02:26 AM, Stephen Warren wrote:
> On 12/18/2013 05:52 AM, Laxman Dewangan wrote:
>> Compare the initial population of default pinmux configuration of Venice2
>> with the chrome branch and add/fix the missing configurations.
> Wow, that's a big chunk of changes. Are you sure this is correct? Why
> was the original patch (which added the pinctrl nodes) so incorrect?
The pinmux which got added is based on the venice2 pinmux spreadsheet
where I covered only the SFIO pin groups.
https://wiki.nvidia.com/engwiki/index.php/Platform_Design_Center/Projects_Archive/PM371#pinmux
After comparing with the chrome, I also added the pinmux for all pins
which are used as GPIO and hence the change is big.
This is complete pinmux based on chrome kernel-next.
I booted chrome with this pinmux and not observe any behavioral change.
> Thierry, I thought you had mentioned comparing the pinctrl setup in
> linux-next with the downstream kernel for Venice2 and only found a
> difference in the PWM settings, which you sent a patch for. However,
> this patch is much larger than that. Where's the disconnect?
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: tegra: fix missing pincontrol configuration for Venice2
Date: Thu, 19 Dec 2013 12:44:24 +0530 [thread overview]
Message-ID: <52B29CD0.1000801@nvidia.com> (raw)
In-Reply-To: <52B20C0D.9030200@wwwdotorg.org>
On Thursday 19 December 2013 02:26 AM, Stephen Warren wrote:
> On 12/18/2013 05:52 AM, Laxman Dewangan wrote:
>> Compare the initial population of default pinmux configuration of Venice2
>> with the chrome branch and add/fix the missing configurations.
> Wow, that's a big chunk of changes. Are you sure this is correct? Why
> was the original patch (which added the pinctrl nodes) so incorrect?
The pinmux which got added is based on the venice2 pinmux spreadsheet
where I covered only the SFIO pin groups.
https://wiki.nvidia.com/engwiki/index.php/Platform_Design_Center/Projects_Archive/PM371#pinmux
After comparing with the chrome, I also added the pinmux for all pins
which are used as GPIO and hence the change is big.
This is complete pinmux based on chrome kernel-next.
I booted chrome with this pinmux and not observe any behavioral change.
> Thierry, I thought you had mentioned comparing the pinctrl setup in
> linux-next with the downstream kernel for Venice2 and only found a
> difference in the PWM settings, which you sent a patch for. However,
> this patch is much larger than that. Where's the disconnect?
next prev parent reply other threads:[~2013-12-19 7:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 12:52 [PATCH 1/2] ARM: tegra: fix missing pincontrol configuration for Venice2 Laxman Dewangan
2013-12-18 12:52 ` Laxman Dewangan
2013-12-18 12:52 ` Laxman Dewangan
2013-12-18 12:52 ` [PATCH V2 2/2] ARM: tegra: add ams AS3722 device to Venice2 DT Laxman Dewangan
2013-12-18 12:52 ` Laxman Dewangan
2013-12-18 12:52 ` Laxman Dewangan
[not found] ` <1387371179-16725-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-18 20:55 ` Stephen Warren
2013-12-18 20:55 ` Stephen Warren
2013-12-18 20:55 ` Stephen Warren
[not found] ` <52B20BB4.50506-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-19 7:28 ` Laxman Dewangan
2013-12-19 7:28 ` Laxman Dewangan
2013-12-19 7:28 ` Laxman Dewangan
[not found] ` <52B2A01D.2000207-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-19 17:24 ` Stephen Warren
2013-12-19 17:24 ` Stephen Warren
2013-12-19 17:24 ` Stephen Warren
2013-12-19 18:23 ` Stephen Warren
2013-12-19 18:23 ` Stephen Warren
2013-12-19 18:23 ` Stephen Warren
[not found] ` <52B33986.5020508-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-20 6:32 ` Laxman Dewangan
2013-12-20 6:32 ` Laxman Dewangan
2013-12-20 6:32 ` Laxman Dewangan
[not found] ` <1387371179-16725-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-18 20:56 ` [PATCH 1/2] ARM: tegra: fix missing pincontrol configuration for Venice2 Stephen Warren
2013-12-18 20:56 ` Stephen Warren
2013-12-18 20:56 ` Stephen Warren
[not found] ` <52B20C0D.9030200-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-19 7:14 ` Laxman Dewangan [this message]
2013-12-19 7:14 ` Laxman Dewangan
2013-12-19 7:14 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B29CD0.1000801@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.