From: Wang Weidong <weidong1991.wang@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: davem@davemloft.net, vyasevich@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] sctp: fix checkpatch errors
Date: Fri, 20 Dec 2013 15:58:38 +0000 [thread overview]
Message-ID: <52B4692E.3060400@gmail.com> (raw)
In-Reply-To: <20131220145121.GE6562@hmsreliant.think-freely.org>
From: Wang Weidong <wangweidong1@huawei.com>
On 2013/12/20 22:51, Neil Horman wrote:
> On Thu, Dec 19, 2013 at 02:52:01PM +0800, Wang Weidong wrote:
>> fix up checkpatch errors:
>> that open brace { should be on the previous line
>> open brace '{' following function declarations go on the next line
>> ERROR: trailing statements should be on next line
>>
>> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> These are all checkpatch errors. You could have just merged them into a big
> patch. Since you didn't, please be a bit more articulate in describing what
> they do in the subject line.
>
> Neil
>
You are right. Sure, I will make it more articulate in v2.
Thanks.
Wang
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Wang Weidong <weidong1991.wang@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: davem@davemloft.net, vyasevich@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] sctp: fix checkpatch errors
Date: Fri, 20 Dec 2013 23:58:38 +0800 [thread overview]
Message-ID: <52B4692E.3060400@gmail.com> (raw)
In-Reply-To: <20131220145121.GE6562@hmsreliant.think-freely.org>
From: Wang Weidong <wangweidong1@huawei.com>
On 2013/12/20 22:51, Neil Horman wrote:
> On Thu, Dec 19, 2013 at 02:52:01PM +0800, Wang Weidong wrote:
>> fix up checkpatch errors:
>> that open brace { should be on the previous line
>> open brace '{' following function declarations go on the next line
>> ERROR: trailing statements should be on next line
>>
>> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> These are all checkpatch errors. You could have just merged them into a big
> patch. Since you didn't, please be a bit more articulate in describing what
> they do in the subject line.
>
> Neil
>
You are right. Sure, I will make it more articulate in v2.
Thanks.
Wang
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-12-20 15:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 6:51 [PATCH net-next 0/5] sctp: fix checkpatch errors Wang Weidong
2013-12-19 6:51 ` Wang Weidong
2013-12-19 6:51 ` [PATCH net-next 1/5] sctp: fix checkpatch errors with space required or prohibited Wang Weidong
2013-12-19 6:51 ` Wang Weidong
2013-12-20 14:26 ` Neil Horman
2013-12-20 14:26 ` Neil Horman
2013-12-19 6:51 ` [PATCH net-next 2/5] sctp: fix checkpatch errors with foo Wang Weidong
2013-12-19 6:51 ` Wang Weidong
2013-12-20 14:44 ` Neil Horman
2013-12-20 14:44 ` Neil Horman
2013-12-19 6:52 ` [PATCH net-next 3/5] sctp: fix checkpatch errors with indent Wang Weidong
2013-12-19 6:52 ` Wang Weidong
2013-12-20 14:49 ` Neil Horman
2013-12-20 14:49 ` Neil Horman
2013-12-19 6:52 ` [PATCH net-next 4/5] sctp: fix checkpatch errors Wang Weidong
2013-12-19 6:52 ` Wang Weidong
2013-12-20 14:51 ` Neil Horman
2013-12-20 14:51 ` Neil Horman
2013-12-20 15:58 ` Wang Weidong [this message]
2013-12-20 15:58 ` Wang Weidong
2013-12-19 6:52 ` [PATCH net-next 5/5] sctp: fix checkpatch errors with //commen Wang Weidong
2013-12-19 6:52 ` Wang Weidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B4692E.3060400@gmail.com \
--to=weidong1991.wang@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.