From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/2] net_sched: optimize tcf_match_indev()
Date: Fri, 20 Dec 2013 15:21:20 -0500 [thread overview]
Message-ID: <52B4A6C0.605@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpWz0NP_6vtYhHSSDW1p3HdALoiNm7JkwL=1-XErHOZ14w@mail.gmail.com>
On 12/20/13 13:55, Cong Wang wrote:
> On Fri, Dec 20, 2013 at 4:14 AM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>>
>> Very impressive catch Eric. I would have 100% caught this with testing
>> (but you caught it by inspecting code!).
>> A simple test that dumps all the actions of a specific type would do.
>> Example in your case, Cong:
>> tc actions ls action mirred
>>
>
> Are you sure??
About 100%
>It is in my test case right after David merged it,
> I still don't see any bug it reports so far.
>
Run before your changes and after your changes and
it will be obvious.
cheers,
jamal
next prev parent reply other threads:[~2013-12-20 20:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 1:34 [PATCH 1/2] net_sched: add struct net pointer to tcf_proto_ops->dump Cong Wang
2013-12-20 1:34 ` [PATCH 2/2] net_sched: optimize tcf_match_indev() Cong Wang
2013-12-20 6:22 ` Eric Dumazet
2013-12-20 6:36 ` Cong Wang
2013-12-20 6:54 ` Eric Dumazet
2013-12-20 8:12 ` Cong Wang
2013-12-20 12:14 ` Jamal Hadi Salim
2013-12-20 18:55 ` Cong Wang
2013-12-20 20:21 ` Jamal Hadi Salim [this message]
2013-12-20 21:36 ` Cong Wang
2013-12-20 23:00 ` Jamal Hadi Salim
2013-12-20 23:07 ` Cong Wang
2013-12-20 23:23 ` Jamal Hadi Salim
2013-12-20 23:49 ` Cong Wang
2013-12-20 23:59 ` Eric Dumazet
2013-12-21 0:12 ` Cong Wang
2013-12-21 21:09 ` Jamal Hadi Salim
2013-12-22 16:26 ` Jamal Hadi Salim
2013-12-22 17:04 ` Jamal Hadi Salim
2013-12-22 17:12 ` Jamal Hadi Salim
2013-12-22 19:33 ` Cong Wang
2013-12-23 13:10 ` Jamal Hadi Salim
2013-12-23 18:36 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B4A6C0.605@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.