* [PATCH] xen/dts: specific bad cell count error
@ 2013-12-22 11:01 tsahee
2013-12-22 17:21 ` Julien Grall
2014-01-07 13:53 ` Ian Campbell
0 siblings, 2 replies; 3+ messages in thread
From: tsahee @ 2013-12-22 11:01 UTC (permalink / raw)
To: xen-devel
Cc: julien.grall, Tsahee Zidenberg, tim, Ian Campbell,
stefano.stabellini
From: Tsahee Zidenberg <tsahee@gmx.com>
Specify in the error message if bad cell count is in device or parent.
Signed-off-by: Tsahee Zidenberg <tsahee@gmx.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/common/device_tree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 9b9a348..327b33c 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -1015,7 +1015,7 @@ static u64 __dt_translate_address(const struct dt_device_node *dev,
bus->count_cells(dev, &na, &ns);
if ( !DT_CHECK_COUNTS(na, ns) )
{
- dt_printk(XENLOG_ERR "dt_parse: Bad cell count for %s\n",
+ dt_printk(XENLOG_ERR "dt_parse: Bad cell count for device %s\n",
dev->full_name);
goto bail;
}
@@ -1050,7 +1050,7 @@ static u64 __dt_translate_address(const struct dt_device_node *dev,
pbus->count_cells(dev, &pna, &pns);
if ( !DT_CHECK_COUNTS(pna, pns) )
{
- printk(XENLOG_ERR "dt_parse: Bad cell count for %s\n",
+ printk(XENLOG_ERR "dt_parse: Bad cell count for parent %s\n",
dev->full_name);
break;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/dts: specific bad cell count error
2013-12-22 11:01 [PATCH] xen/dts: specific bad cell count error tsahee
@ 2013-12-22 17:21 ` Julien Grall
2014-01-07 13:53 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: Julien Grall @ 2013-12-22 17:21 UTC (permalink / raw)
To: tsahee, xen-devel; +Cc: tim, Ian Campbell, stefano.stabellini
On 12/22/2013 11:01 AM, tsahee@gmx.com wrote:
> From: Tsahee Zidenberg <tsahee@gmx.com>
>
> Specify in the error message if bad cell count is in device or parent.
>
> Signed-off-by: Tsahee Zidenberg <tsahee@gmx.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
--
Julien Grall
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/dts: specific bad cell count error
2013-12-22 11:01 [PATCH] xen/dts: specific bad cell count error tsahee
2013-12-22 17:21 ` Julien Grall
@ 2014-01-07 13:53 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-01-07 13:53 UTC (permalink / raw)
To: tsahee; +Cc: julien.grall, stefano.stabellini, tim, xen-devel
On Sun, 2013-12-22 at 13:01 +0200, tsahee@gmx.com wrote:
> From: Tsahee Zidenberg <tsahee@gmx.com>
>
> Specify in the error message if bad cell count is in device or parent.
>
> Signed-off-by: Tsahee Zidenberg <tsahee@gmx.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
RM hat: clearly no risk to the release here and improve the diagnostics
in a useful way.
Applied, thanks.
Ian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-07 13:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-22 11:01 [PATCH] xen/dts: specific bad cell count error tsahee
2013-12-22 17:21 ` Julien Grall
2014-01-07 13:53 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.