From: Jonathan Cameron <jic23@kernel.org>
To: Nicolas Ferre <nicolas.ferre@atmel.com>,
Boris BREZILLON <b.brezillon@overkiz.com>,
Rob Landley <rob@landley.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: at91: document ADC clock properties
Date: Sun, 22 Dec 2013 18:05:49 +0000 [thread overview]
Message-ID: <52B729FD.7020507@kernel.org> (raw)
In-Reply-To: <52B316A9.1060407@atmel.com>
On 12/19/13 15:54, Nicolas Ferre wrote:
> On 17/12/2013 17:16, Boris BREZILLON :
>> Document the clock properties required by the at91 ADC driver.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Looks fine to me. I'm just waiting on an ack from a device tree maintainer
(or the 3 weeks to pass so I can pick it up anyway ;)
>
>> ---
>> .../devicetree/bindings/arm/atmel-adc.txt | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> index d106146..9a1175b 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> @@ -5,6 +5,9 @@ Required properties:
>> <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
>> - reg: Should contain ADC registers location and length
>> - interrupts: Should contain the IRQ line for the ADC
>> + - clock-names: tuple listing input clock names.
>> + Required elements: "adc_clk", "adc_op_clk".
>> + - clocks: phandles to input clocks.
>> - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
>> device
>> - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
>> @@ -44,6 +47,8 @@ adc0: adc@fffb0000 {
>> compatible = "atmel,at91sam9260-adc";
>> reg = <0xfffb0000 0x100>;
>> interrupts = <20 4>;
>> + clocks = <&adc_clk>, <&adc_op_clk>;
>> + clock-names = "adc_clk", "adc_op_clk";
>> atmel,adc-channel-base = <0x30>;
>> atmel,adc-channels-used = <0xff>;
>> atmel,adc-drdy-mask = <0x10000>;
>>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iio: at91: document ADC clock properties
Date: Sun, 22 Dec 2013 18:05:49 +0000 [thread overview]
Message-ID: <52B729FD.7020507@kernel.org> (raw)
In-Reply-To: <52B316A9.1060407@atmel.com>
On 12/19/13 15:54, Nicolas Ferre wrote:
> On 17/12/2013 17:16, Boris BREZILLON :
>> Document the clock properties required by the at91 ADC driver.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Looks fine to me. I'm just waiting on an ack from a device tree maintainer
(or the 3 weeks to pass so I can pick it up anyway ;)
>
>> ---
>> .../devicetree/bindings/arm/atmel-adc.txt | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> index d106146..9a1175b 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> @@ -5,6 +5,9 @@ Required properties:
>> <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
>> - reg: Should contain ADC registers location and length
>> - interrupts: Should contain the IRQ line for the ADC
>> + - clock-names: tuple listing input clock names.
>> + Required elements: "adc_clk", "adc_op_clk".
>> + - clocks: phandles to input clocks.
>> - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
>> device
>> - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
>> @@ -44,6 +47,8 @@ adc0: adc at fffb0000 {
>> compatible = "atmel,at91sam9260-adc";
>> reg = <0xfffb0000 0x100>;
>> interrupts = <20 4>;
>> + clocks = <&adc_clk>, <&adc_op_clk>;
>> + clock-names = "adc_clk", "adc_op_clk";
>> atmel,adc-channel-base = <0x30>;
>> atmel,adc-channels-used = <0xff>;
>> atmel,adc-drdy-mask = <0x10000>;
>>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Boris BREZILLON
<b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>,
Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iio: at91: document ADC clock properties
Date: Sun, 22 Dec 2013 18:05:49 +0000 [thread overview]
Message-ID: <52B729FD.7020507@kernel.org> (raw)
In-Reply-To: <52B316A9.1060407-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
On 12/19/13 15:54, Nicolas Ferre wrote:
> On 17/12/2013 17:16, Boris BREZILLON :
>> Document the clock properties required by the at91 ADC driver.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>
>
> Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Looks fine to me. I'm just waiting on an ack from a device tree maintainer
(or the 3 weeks to pass so I can pick it up anyway ;)
>
>> ---
>> .../devicetree/bindings/arm/atmel-adc.txt | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> index d106146..9a1175b 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> @@ -5,6 +5,9 @@ Required properties:
>> <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
>> - reg: Should contain ADC registers location and length
>> - interrupts: Should contain the IRQ line for the ADC
>> + - clock-names: tuple listing input clock names.
>> + Required elements: "adc_clk", "adc_op_clk".
>> + - clocks: phandles to input clocks.
>> - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
>> device
>> - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
>> @@ -44,6 +47,8 @@ adc0: adc@fffb0000 {
>> compatible = "atmel,at91sam9260-adc";
>> reg = <0xfffb0000 0x100>;
>> interrupts = <20 4>;
>> + clocks = <&adc_clk>, <&adc_op_clk>;
>> + clock-names = "adc_clk", "adc_op_clk";
>> atmel,adc-channel-base = <0x30>;
>> atmel,adc-channels-used = <0xff>;
>> atmel,adc-drdy-mask = <0x10000>;
>>
>
>
next prev parent reply other threads:[~2013-12-22 18:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 16:16 [PATCH] iio: at91: document ADC clock properties Boris BREZILLON
2013-12-17 16:16 ` Boris BREZILLON
2013-12-19 15:54 ` Nicolas Ferre
2013-12-19 15:54 ` Nicolas Ferre
2013-12-19 15:54 ` Nicolas Ferre
2013-12-22 18:05 ` Jonathan Cameron [this message]
2013-12-22 18:05 ` Jonathan Cameron
2013-12-22 18:05 ` Jonathan Cameron
2014-01-11 16:29 ` Jonathan Cameron
2014-01-11 16:29 ` Jonathan Cameron
2014-01-11 16:29 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B729FD.7020507@kernel.org \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=b.brezillon@overkiz.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.