From: Antonio Quartulli <antonio@meshcoding.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
mareklindner@neomailbox.ch
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb
Date: Mon, 23 Dec 2013 01:11:10 +0100 [thread overview]
Message-ID: <52B77F9E.8040201@meshcoding.com> (raw)
In-Reply-To: <20131222.185027.572777902017063381.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On 23/12/13 00:50, David Miller wrote:
>
> See nf_reset() and skb_scrub_packet(). Do not reinvent the
> wheel.
>
Hello David,
after some discussion[1] the suggestion was to keep the behaviour as
less intrusive as possible, thus I avoided any nf_reset() (and similar)
and I directly wrote my function that calls nf_bridge_put() only.
Do you think it is safe to use nf_reset() directly?
Pablo was worried about "strange" user configurations that may break
because of this.
(Even if somebody may argue that in this case user configurations are
probably broken, not the kernel :-) ).
Regards,
[1] http://thread.gmane.org/gmane.linux.network/286965/focus=287502
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <antonio@meshcoding.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
mareklindner@neomailbox.ch
Subject: Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb
Date: Mon, 23 Dec 2013 01:11:10 +0100 [thread overview]
Message-ID: <52B77F9E.8040201@meshcoding.com> (raw)
In-Reply-To: <20131222.185027.572777902017063381.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On 23/12/13 00:50, David Miller wrote:
>
> See nf_reset() and skb_scrub_packet(). Do not reinvent the
> wheel.
>
Hello David,
after some discussion[1] the suggestion was to keep the behaviour as
less intrusive as possible, thus I avoided any nf_reset() (and similar)
and I directly wrote my function that calls nf_bridge_put() only.
Do you think it is safe to use nf_reset() directly?
Pablo was worried about "strange" user configurations that may break
because of this.
(Even if somebody may argue that in this case user configurations are
probably broken, not the kernel :-) ).
Regards,
[1] http://thread.gmane.org/gmane.linux.network/286965/focus=287502
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-23 0:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 0:15 [B.A.T.M.A.N.] pull request [net]: batman-adv 2013-12-19 Antonio Quartulli
2013-12-19 0:15 ` Antonio Quartulli
2013-12-19 0:15 ` [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb Antonio Quartulli
2013-12-19 0:15 ` Antonio Quartulli
2013-12-22 23:50 ` [B.A.T.M.A.N.] " David Miller
2013-12-22 23:50 ` David Miller
2013-12-23 0:11 ` Antonio Quartulli [this message]
2013-12-23 0:11 ` Antonio Quartulli
2013-12-23 0:16 ` [B.A.T.M.A.N.] " David Miller
2013-12-23 0:16 ` David Miller
2013-12-23 0:19 ` [B.A.T.M.A.N.] " Antonio Quartulli
2013-12-23 0:19 ` Antonio Quartulli
2013-12-19 0:15 ` [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: fix alignment for batadv_coded_packet Antonio Quartulli
2013-12-19 0:15 ` Antonio Quartulli
2013-12-19 0:15 ` [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: fix header alignment by unrolling batadv_header Antonio Quartulli
2013-12-19 0:15 ` Antonio Quartulli
2013-12-19 0:15 ` [B.A.T.M.A.N.] [PATCH 4/6] batman-adv: fix size of batadv_icmp_header Antonio Quartulli
2013-12-19 0:15 ` Antonio Quartulli
2013-12-19 0:15 ` [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: fix size of batadv_bla_claim_dst Antonio Quartulli
2013-12-19 0:15 ` Antonio Quartulli
2013-12-19 0:15 ` [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: fix alignment for batadv_tvlv_tt_change Antonio Quartulli
2013-12-19 0:15 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B77F9E.8040201@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.