All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <jbeulich@suse.com>, tsahee@gmx.com, xen-devel@lists.xen.org
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com,
	stefano.stabellini@eu.citrix.com
Subject: Re: misplaced const
Date: Tue, 24 Dec 2013 11:33:08 +0000	[thread overview]
Message-ID: <52B970F4.4040300@linaro.org> (raw)
In-Reply-To: <52B8059B02000078000A9C96@nat28.tlf.novell.com>



On 12/23/2013 09:42 AM, Jan Beulich wrote:
>>>> <tsahee@gmx.com> 12/22/13 3:52 PM >>>
>> --- a/xen/drivers/char/ns16550.c
>> +++ b/xen/drivers/char/ns16550.c
>> @@ -817,6 +817,7 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev,
>> static const char const *ns16550_dt_compat[] __initconst =
>
> This being ARM specific code, could someone please submit a patch to prevent
> problems going forward with the duplicate const here (the second one really
> belongs _after_ the *)?

Hi Jan,

Thanks for spotting the error. I noticed that every serial drivers which 
support Device Tree are affected by the duplicated const.

I have sent a patch on the ML: https://patches.linaro.org/22744/

Cheers,

-- 
Julien Grall

      reply	other threads:[~2013-12-24 11:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-22 10:59 [PATCH] ns16550: support ns16550a tsahee
2013-12-22 17:22 ` Julien Grall
2014-01-07 13:54   ` Ian Campbell
2013-12-23  9:42 ` misplaced const (was: Re: [PATCH] ns16550: support ns16550a) Jan Beulich
2013-12-24 11:33   ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B970F4.4040300@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tsahee@gmx.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.