All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: balbi@ti.com
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, linus.walleij@linaro.org,
	linux@arm.linux.org.uk, tony@atomide.com, rnayak@ti.com,
	marc.zyngier@arm.com, grant.likely@linaro.org,
	mark.rutland@arm.com, robherring2@gmail.com, tglx@linutronix.de,
	galak@codeaurora.org, rob.herring@calxeda.com,
	santosh.shilimkar@ti.com, nm@ti.com, bcousson@baylibre.com
Subject: Re: [PATCH V5 2/4] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP
Date: Fri, 27 Dec 2013 14:07:03 +0530	[thread overview]
Message-ID: <52BD3C2F.9010409@ti.com> (raw)
In-Reply-To: <20131226200106.GA30559@saruman.home>

Hi Felipe,

On Friday 27 December 2013 01:31 AM, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Dec 03, 2013 at 03:57:23PM +0530, Sricharan R wrote:
>> +static const struct of_device_id crossbar_match[] __initconst = {
>> +	{ .compatible = "ti,irq-crossbar" },
>> +	{}
>> +};
>> +
>> +int irqcrossbar_init(void)
>> +{
>> +	struct device_node *np;
>> +	np = of_find_matching_node(NULL, crossbar_match);
>> +	if (!np)
>> +		return -ENODEV;
>> +
>> +	crossbar_of_init(np);
>> +	return 0;
>> +}
> 
> instead, please use IRQCHIP_DECLARE() then you won't need to expose this
> symbol to be used by arch/arm/ code.
> 

Crossbar node does not have a "interrupt-controller" property and
not a regular Interrupt controller. This was added in here
after all below discussions

 https://lkml.org/lkml/2013/9/18/540

So IRQCHIP_DECLARE() macro cannot be used here.

Regards,
 Sricharan

WARNING: multiple messages have this Message-ID (diff)
From: r.sricharan@ti.com (Sricharan R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 2/4] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP
Date: Fri, 27 Dec 2013 14:07:03 +0530	[thread overview]
Message-ID: <52BD3C2F.9010409@ti.com> (raw)
In-Reply-To: <20131226200106.GA30559@saruman.home>

Hi Felipe,

On Friday 27 December 2013 01:31 AM, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Dec 03, 2013 at 03:57:23PM +0530, Sricharan R wrote:
>> +static const struct of_device_id crossbar_match[] __initconst = {
>> +	{ .compatible = "ti,irq-crossbar" },
>> +	{}
>> +};
>> +
>> +int irqcrossbar_init(void)
>> +{
>> +	struct device_node *np;
>> +	np = of_find_matching_node(NULL, crossbar_match);
>> +	if (!np)
>> +		return -ENODEV;
>> +
>> +	crossbar_of_init(np);
>> +	return 0;
>> +}
> 
> instead, please use IRQCHIP_DECLARE() then you won't need to expose this
> symbol to be used by arch/arm/ code.
> 

Crossbar node does not have a "interrupt-controller" property and
not a regular Interrupt controller. This was added in here
after all below discussions

 https://lkml.org/lkml/2013/9/18/540

So IRQCHIP_DECLARE() macro cannot be used here.

Regards,
 Sricharan

WARNING: multiple messages have this Message-ID (diff)
From: Sricharan R <r.sricharan@ti.com>
To: <balbi@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-doc@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-omap@vger.kernel.org>, <linus.walleij@linaro.org>,
	<linux@arm.linux.org.uk>, <tony@atomide.com>, <rnayak@ti.com>,
	<marc.zyngier@arm.com>, <grant.likely@linaro.org>,
	<mark.rutland@arm.com>, <robherring2@gmail.com>,
	<tglx@linutronix.de>, <galak@codeaurora.org>,
	<rob.herring@calxeda.com>, <santosh.shilimkar@ti.com>,
	<nm@ti.com>, <bcousson@baylibre.com>
Subject: Re: [PATCH V5 2/4] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP
Date: Fri, 27 Dec 2013 14:07:03 +0530	[thread overview]
Message-ID: <52BD3C2F.9010409@ti.com> (raw)
In-Reply-To: <20131226200106.GA30559@saruman.home>

Hi Felipe,

On Friday 27 December 2013 01:31 AM, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Dec 03, 2013 at 03:57:23PM +0530, Sricharan R wrote:
>> +static const struct of_device_id crossbar_match[] __initconst = {
>> +	{ .compatible = "ti,irq-crossbar" },
>> +	{}
>> +};
>> +
>> +int irqcrossbar_init(void)
>> +{
>> +	struct device_node *np;
>> +	np = of_find_matching_node(NULL, crossbar_match);
>> +	if (!np)
>> +		return -ENODEV;
>> +
>> +	crossbar_of_init(np);
>> +	return 0;
>> +}
> 
> instead, please use IRQCHIP_DECLARE() then you won't need to expose this
> symbol to be used by arch/arm/ code.
> 

Crossbar node does not have a "interrupt-controller" property and
not a regular Interrupt controller. This was added in here
after all below discussions

 https://lkml.org/lkml/2013/9/18/540

So IRQCHIP_DECLARE() macro cannot be used here.

Regards,
 Sricharan

  reply	other threads:[~2013-12-27  8:37 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 10:27 [PATCH V5 0/4] DRIVERS: IRQCHIP: Add support for crossbar IP Sricharan R
2013-12-03 10:27 ` Sricharan R
2013-12-03 10:27 ` Sricharan R
2013-12-03 10:27 ` [PATCH V5 1/4] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs Sricharan R
2013-12-03 10:27   ` Sricharan R
2013-12-03 10:27   ` Sricharan R
2013-12-03 10:27 ` [PATCH V5 2/4] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP Sricharan R
2013-12-03 10:27   ` Sricharan R
2013-12-03 10:27   ` Sricharan R
2013-12-26 20:01   ` Felipe Balbi
2013-12-26 20:01     ` Felipe Balbi
2013-12-26 20:01     ` Felipe Balbi
2013-12-27  8:37     ` Sricharan R [this message]
2013-12-27  8:37       ` Sricharan R
2013-12-27  8:37       ` Sricharan R
2014-01-16 10:22   ` Sricharan R
2014-01-16 10:22     ` Sricharan R
2014-01-16 10:22     ` Sricharan R
2014-02-03 11:29     ` Sricharan R
2014-02-03 11:29       ` Sricharan R
2014-02-03 11:29       ` Sricharan R
2014-02-04 16:14       ` Thomas Gleixner
2014-02-04 16:14         ` Thomas Gleixner
2014-02-05 13:11         ` Sricharan R
2014-02-05 13:11           ` Sricharan R
2014-02-05 13:11           ` Sricharan R
2014-02-05 14:11           ` Sricharan R
2014-02-05 14:11             ` Sricharan R
2014-02-05 14:11             ` Sricharan R
2014-02-26  4:56             ` Sricharan R
2014-02-26  4:56               ` Sricharan R
2014-02-26  4:56               ` Sricharan R
     [not found]             ` <52F24683.9060200-l0cyMroinI0@public.gmane.org>
2014-02-28 21:36               ` Tony Lindgren
2014-02-28 21:36                 ` Tony Lindgren
2014-02-28 21:36                 ` Tony Lindgren
     [not found] ` <1386066445-28245-1-git-send-email-r.sricharan-l0cyMroinI0@public.gmane.org>
2013-12-03 10:27   ` [PATCH V5 3/4] ARM: OMAP4+: Correct Wakeup-gen code to use physical irq number Sricharan R
2013-12-03 10:27     ` Sricharan R
2013-12-03 10:27     ` Sricharan R
2013-12-03 10:27 ` [PATCH V5 4/4] ARM: DRA: Enable Crossbar IP support for DRA7XX Sricharan R
2013-12-03 10:27   ` Sricharan R
2013-12-03 10:27   ` Sricharan R
2013-12-18  9:19 ` [PATCH V5 0/4] DRIVERS: IRQCHIP: Add support for crossbar IP Sricharan R
2013-12-18  9:19   ` Sricharan R
2013-12-18  9:19   ` Sricharan R
2013-12-26  4:52   ` Sricharan R
2013-12-26  4:52     ` Sricharan R
2013-12-26  4:52     ` Sricharan R
2013-12-26 17:44     ` Santosh Shilimkar
2013-12-26 17:44       ` Santosh Shilimkar
2013-12-26 17:44       ` Santosh Shilimkar
2013-12-27 13:49       ` Sricharan R
2013-12-27 13:49         ` Sricharan R
2013-12-27 13:49         ` Sricharan R
2013-12-30  6:28         ` Sricharan R
2013-12-30  6:28           ` Sricharan R
2013-12-30  6:28           ` Sricharan R
2014-01-07 23:07           ` Tony Lindgren
2014-01-07 23:07             ` Tony Lindgren
     [not found]             ` <20140107230733.GD5074-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-01-07 23:55               ` Tony Lindgren
2014-01-07 23:55                 ` Tony Lindgren
2014-01-07 23:55                 ` Tony Lindgren
2014-01-08 13:18                 ` Sricharan R
2014-01-08 13:18                   ` Sricharan R
2014-01-08 13:18                   ` Sricharan R
     [not found]                   ` <52CD5010.6030309-l0cyMroinI0@public.gmane.org>
2014-01-08 19:18                     ` Tony Lindgren
2014-01-08 19:18                       ` Tony Lindgren
2014-01-08 19:18                       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52BD3C2F.9010409@ti.com \
    --to=r.sricharan@ti.com \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=nm@ti.com \
    --cc=rnayak@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=robherring2@gmail.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.