From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Benjamin <bcrl@kvack.org>,
linux-aio@kvack.org, fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] aio: optimize free kioctx slot search
Date: Fri, 27 Dec 2013 18:32:24 +0800 [thread overview]
Message-ID: <52BD5738.4010308@cn.fujitsu.com> (raw)
In-Reply-To: <20131226141356.GH11091@parisc-linux.org>
Hi Matthew,
On 12/26/2013 10:13 PM, Matthew Wilcox wrote:
> On Thu, Dec 26, 2013 at 06:22:10PM +0800, Gu Zheng wrote:
>> to the new free slot if it's smaller than 'next_free'. So that we can
>> ensure that the slots before 'next_free' are all used, and the search can start
>> from 'next_free' to reduce the search and improve the performance.
>
> Have you benchmarked it? What kinds of improvements are you seeing?
Not yet. But the improvement is obvious, we can always reduce the search region and
improve the hit rate when trying to find a free slot with this change.
Regards,
Gu
>
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
WARNING: multiple messages have this Message-ID (diff)
From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Benjamin <bcrl@kvack.org>,
linux-aio@kvack.org, fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] aio: optimize free kioctx slot search
Date: Fri, 27 Dec 2013 18:32:24 +0800 [thread overview]
Message-ID: <52BD5738.4010308@cn.fujitsu.com> (raw)
In-Reply-To: <20131226141356.GH11091@parisc-linux.org>
Hi Matthew,
On 12/26/2013 10:13 PM, Matthew Wilcox wrote:
> On Thu, Dec 26, 2013 at 06:22:10PM +0800, Gu Zheng wrote:
>> to the new free slot if it's smaller than 'next_free'. So that we can
>> ensure that the slots before 'next_free' are all used, and the search can start
>> from 'next_free' to reduce the search and improve the performance.
>
> Have you benchmarked it? What kinds of improvements are you seeing?
Not yet. But the improvement is obvious, we can always reduce the search region and
improve the hit rate when trying to find a free slot with this change.
Regards,
Gu
>
next prev parent reply other threads:[~2013-12-27 10:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 10:22 [PATCH] aio: optimize free kioctx slot search Gu Zheng
2013-12-26 10:22 ` Gu Zheng
2013-12-26 10:39 ` Miao Xie
2013-12-26 10:39 ` Miao Xie
2013-12-26 14:13 ` Matthew Wilcox
2013-12-27 10:32 ` Gu Zheng [this message]
2013-12-27 10:32 ` Gu Zheng
2013-12-27 12:32 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BD5738.4010308@cn.fujitsu.com \
--to=guz.fnst@cn.fujitsu.com \
--cc=bcrl@kvack.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.