* [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr compare @ 2013-12-28 6:17 Ding Tianhong 2013-12-28 13:15 ` Jeff Kirsher 2014-01-11 3:30 ` Brown, Aaron F 0 siblings, 2 replies; 4+ messages in thread From: Ding Tianhong @ 2013-12-28 6:17 UTC (permalink / raw) To: Jeff Kirsher, Jesse Brandeburg, Carolyn Wyborny, Don Skidmore, David S. Miller, Netdev, linux-kernel@vger.kernel.org Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> Cc: Carolyn Wyborny <carolyn.wyborny@intel.com> Cc: Don Skidmore <donald.c.skidmore@intel.com> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> --- drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c index 04bf22e..675435f 100644 --- a/drivers/net/ethernet/intel/igbvf/netdev.c +++ b/drivers/net/ethernet/intel/igbvf/netdev.c @@ -1745,7 +1745,7 @@ static int igbvf_set_mac(struct net_device *netdev, void *p) hw->mac.ops.rar_set(hw, hw->mac.addr, 0); - if (memcmp(addr->sa_data, hw->mac.addr, 6)) + if (!ether_addr_equal(addr->sa_data, hw->mac.addr)) return -EADDRNOTAVAIL; memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); -- 1.8.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr compare 2013-12-28 6:17 [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr compare Ding Tianhong @ 2013-12-28 13:15 ` Jeff Kirsher 2014-01-11 3:30 ` Brown, Aaron F 1 sibling, 0 replies; 4+ messages in thread From: Jeff Kirsher @ 2013-12-28 13:15 UTC (permalink / raw) To: Ding Tianhong Cc: Jesse Brandeburg, Carolyn Wyborny, Don Skidmore, David S. Miller, Netdev, linux-kernel@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 586 bytes --] On Sat, 2013-12-28 at 14:17 +0800, Ding Tianhong wrote: > Use possibly more efficient ether_addr_equal > to instead of memcmp. > > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: Carolyn Wyborny <carolyn.wyborny@intel.com> > Cc: Don Skidmore <donald.c.skidmore@intel.com> > Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> > --- > drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks Ding, I will update the patch in my queue with this updated version. [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr compare 2013-12-28 6:17 [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr compare Ding Tianhong @ 2014-01-11 3:30 ` Brown, Aaron F 2014-01-11 3:30 ` Brown, Aaron F 1 sibling, 0 replies; 4+ messages in thread From: Brown, Aaron F @ 2014-01-11 3:30 UTC (permalink / raw) To: Ding Tianhong, Kirsher, Jeffrey T, Brandeburg, Jesse, Wyborny, Carolyn, Skidmore, Donald C, David S. Miller, Netdev, linux-kernel@vger.kernel.org [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1869 bytes --] > From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] > On Behalf Of Ding Tianhong > Sent: Friday, December 27, 2013 10:17 PM > To: Kirsher, Jeffrey T; Brandeburg, Jesse; Wyborny, Carolyn; Skidmore, > Donald C; David S. Miller; Netdev; linux-kernel@vger.kernel.org > Subject: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr > compare > > Use possibly more efficient ether_addr_equal to instead of memcmp. > > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: Carolyn Wyborny <carolyn.wyborny@intel.com> > Cc: Don Skidmore <donald.c.skidmore@intel.com> > Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> Signed-off-by: Aaron Brown <aaron.f.brown@intel.com> Tested by: Aaron Brown <aaron.f.brown@intel.com> > --- > drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c > b/drivers/net/ethernet/intel/igbvf/netdev.c > index 04bf22e..675435f 100644 > --- a/drivers/net/ethernet/intel/igbvf/netdev.c > +++ b/drivers/net/ethernet/intel/igbvf/netdev.c > @@ -1745,7 +1745,7 @@ static int igbvf_set_mac(struct net_device *netdev, > void *p) > > hw->mac.ops.rar_set(hw, hw->mac.addr, 0); > > - if (memcmp(addr->sa_data, hw->mac.addr, 6)) > + if (!ether_addr_equal(addr->sa_data, hw->mac.addr)) > return -EADDRNOTAVAIL; > > memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); > -- > 1.8.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥ ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr compare @ 2014-01-11 3:30 ` Brown, Aaron F 0 siblings, 0 replies; 4+ messages in thread From: Brown, Aaron F @ 2014-01-11 3:30 UTC (permalink / raw) To: Ding Tianhong, Kirsher, Jeffrey T, Brandeburg, Jesse, Wyborny, Carolyn, Skidmore, Donald C, David S. Miller, Netdev, linux-kernel@vger.kernel.org > From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] > On Behalf Of Ding Tianhong > Sent: Friday, December 27, 2013 10:17 PM > To: Kirsher, Jeffrey T; Brandeburg, Jesse; Wyborny, Carolyn; Skidmore, > Donald C; David S. Miller; Netdev; linux-kernel@vger.kernel.org > Subject: [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr > compare > > Use possibly more efficient ether_addr_equal to instead of memcmp. > > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: Carolyn Wyborny <carolyn.wyborny@intel.com> > Cc: Don Skidmore <donald.c.skidmore@intel.com> > Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> Signed-off-by: Aaron Brown <aaron.f.brown@intel.com> Tested by: Aaron Brown <aaron.f.brown@intel.com> > --- > drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c > b/drivers/net/ethernet/intel/igbvf/netdev.c > index 04bf22e..675435f 100644 > --- a/drivers/net/ethernet/intel/igbvf/netdev.c > +++ b/drivers/net/ethernet/intel/igbvf/netdev.c > @@ -1745,7 +1745,7 @@ static int igbvf_set_mac(struct net_device *netdev, > void *p) > > hw->mac.ops.rar_set(hw, hw->mac.addr, 0); > > - if (memcmp(addr->sa_data, hw->mac.addr, 6)) > + if (!ether_addr_equal(addr->sa_data, hw->mac.addr)) > return -EADDRNOTAVAIL; > > memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len); > -- > 1.8.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-11 3:30 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-12-28 6:17 [PATCH net-next v2 06/20] net: igbvf: slight optimization of addr compare Ding Tianhong 2013-12-28 13:15 ` Jeff Kirsher 2014-01-11 3:30 ` Brown, Aaron F 2014-01-11 3:30 ` Brown, Aaron F
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.