[Powertop] 64bit-portability-issue

[Powertop] 64bit-portability-issue

[denisart benjamin2]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]


Hello everyone,

I'm a openSUSE maintainer and I have an issue with powertop 2.5 about
implicit implementation, classic stdio.h,... Obviously, I tried to patch
event-parce.c but it doesn't work

I: Program is using implicit definitions of functions getting
    pointers or implemented by macros. These functions need to use their
    correct prototypes to allow correct argument passing on e.g. x86_64 .
    - Implicit memory/string functions need #include <string.h>.
    - Implicit *printf functions need #include <stdio.h>.
    - Implicit *printf functions need #include <stdio.h>.
    - Implicit *read* functions need #include <unistd.h>.
    - Implicit *recv* functions need #include <sys/socket.h>.
W: powertop implicit-pointer-decl event-parse.c:856
E: powertop 64bit-portability-issue event-parse.c:5120

Have a nice day

Benjamin

Re: [Powertop] 64bit-portability-issue

[Arjan van de Ven]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On 12/28/2013 2:52 PM, denisart benjamin2 wrote:
>
> Hello everyone,
>
> I'm a openSUSE maintainer and I have an issue with powertop 2.5 about
> implicit implementation, classic stdio.h,... Obviously, I tried to patch
> event-parce.c but it doesn't work
>
> I: Program is using implicit definitions of functions getting
>     pointers or implemented by macros. These functions need to use their
>     correct prototypes to allow correct argument passing on e.g. x86_64 .
>     - Implicit memory/string functions need #include <string.h>.
>     - Implicit *printf functions need #include <stdio.h>.
>     - Implicit *printf functions need #include <stdio.h>.
>     - Implicit *read* functions need #include <unistd.h>.
>     - Implicit *recv* functions need #include <sys/socket.h>.
> W: powertop implicit-pointer-decl event-parse.c:856
> E: powertop 64bit-portability-issue event-parse.c:5120
>
adding Steve since this is his upstream code...

btw this code will be a standalone upstream library very soon...
... I assume OpenSUSE will include this library ?