Re: [Qemu-devel] [PATCH RFC 3/3] tests: add test cases for qapi event support

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

>>>
>>>> + OrderedDict([('event', 'EVENT_A')]),
>>>> + OrderedDict([('event', 'EVENT_B'), ('data', OrderedDict())]),
>>>
>>> Shouldn't the omission of 'data' be the same as 'data':{}?
>>>
>>
>>    I didn't touch the "{ }" parsing part, maybe an existing parsing
>> style, will check it.
>>

   Checked the code, it is generated by tests/qapi-schema/test-qapi.py:

try:
     exprs = parse_schema(sys.stdin)
except SystemExit:
     raise
except:
     print >>sys.stderr, "Crashed:", sys.exc_info()[0]
     exit(1)

pprint(exprs)

   I think it worked as expectation for exprs.

>>>> +++ b/tests/test-qmp-event.c
>>>> @@ -0,0 +1,250 @@
>>>> +/*
>>>> + * QMP Input Visitor unit-tests.
>>>> + *
>>>> + * Copyright (C) 2011 Red Hat Inc.
>>>
>>> Unusual choice of copyright year and ownership.
>>>
>>   yep, will fix.
>>
>>
>
>