All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: xen-devel@lists.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] xen/pci: Fix build on non-x86
Date: Thu, 2 Jan 2014 11:50:40 +0000	[thread overview]
Message-ID: <52C55290.8070703@citrix.com> (raw)
In-Reply-To: <1388519187.2900.99.camel@deadeye.wl.decadent.org.uk>

On 31/12/13 19:46, Ben Hutchings wrote:
> We can't include <asm/pci_x86.h> if this isn't x86, and we only need
> it if CONFIG_PCI_MMCONFIG is enabled.
> 
> Fixes: 8deb3eb1461e ('xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved for MCFG areas.')
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

> --- a/drivers/xen/pci.c
> +++ b/drivers/xen/pci.c
> @@ -26,7 +26,9 @@
>  #include <asm/xen/hypervisor.h>
>  #include <asm/xen/hypercall.h>
>  #include "../pci/pci.h"
> +#ifdef CONFIG_PCI_MMCONFIG
>  #include <asm/pci_x86.h>
> +#endif
>  
>  static bool __read_mostly pci_seg_supported = true;

  reply	other threads:[~2014-01-02 11:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-31 19:46 [PATCH] xen/pci: Fix build on non-x86 Ben Hutchings
2014-01-02 11:50 ` David Vrabel [this message]
2014-01-06  9:58 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C55290.8070703@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=ben@decadent.org.uk \
    --cc=boris.ostrovsky@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.