* [PATCH] xen/pci: Fix build on non-x86
@ 2013-12-31 19:46 Ben Hutchings
2014-01-02 11:50 ` David Vrabel
2014-01-06 9:58 ` Ian Campbell
0 siblings, 2 replies; 3+ messages in thread
From: Ben Hutchings @ 2013-12-31 19:46 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel; +Cc: xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 618 bytes --]
We can't include <asm/pci_x86.h> if this isn't x86, and we only need
it if CONFIG_PCI_MMCONFIG is enabled.
Fixes: 8deb3eb1461e ('xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved for MCFG areas.')
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
--- a/drivers/xen/pci.c
+++ b/drivers/xen/pci.c
@@ -26,7 +26,9 @@
#include <asm/xen/hypervisor.h>
#include <asm/xen/hypercall.h>
#include "../pci/pci.h"
+#ifdef CONFIG_PCI_MMCONFIG
#include <asm/pci_x86.h>
+#endif
static bool __read_mostly pci_seg_supported = true;
--
Ben Hutchings
Logic doesn't apply to the real world. - Marvin Minsky
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xen/pci: Fix build on non-x86
2013-12-31 19:46 [PATCH] xen/pci: Fix build on non-x86 Ben Hutchings
@ 2014-01-02 11:50 ` David Vrabel
2014-01-06 9:58 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: David Vrabel @ 2014-01-02 11:50 UTC (permalink / raw)
To: Ben Hutchings; +Cc: xen-devel, Boris Ostrovsky
On 31/12/13 19:46, Ben Hutchings wrote:
> We can't include <asm/pci_x86.h> if this isn't x86, and we only need
> it if CONFIG_PCI_MMCONFIG is enabled.
>
> Fixes: 8deb3eb1461e ('xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved for MCFG areas.')
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
> --- a/drivers/xen/pci.c
> +++ b/drivers/xen/pci.c
> @@ -26,7 +26,9 @@
> #include <asm/xen/hypervisor.h>
> #include <asm/xen/hypercall.h>
> #include "../pci/pci.h"
> +#ifdef CONFIG_PCI_MMCONFIG
> #include <asm/pci_x86.h>
> +#endif
>
> static bool __read_mostly pci_seg_supported = true;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xen/pci: Fix build on non-x86
2013-12-31 19:46 [PATCH] xen/pci: Fix build on non-x86 Ben Hutchings
2014-01-02 11:50 ` David Vrabel
@ 2014-01-06 9:58 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-01-06 9:58 UTC (permalink / raw)
To: Ben Hutchings; +Cc: xen-devel, Boris Ostrovsky, David Vrabel
On Tue, 2013-12-31 at 20:46 +0100, Ben Hutchings wrote:
> We can't include <asm/pci_x86.h> if this isn't x86, and we only need
> it if CONFIG_PCI_MMCONFIG is enabled.
>
> Fixes: 8deb3eb1461e ('xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved for MCFG areas.')
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-06 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-31 19:46 [PATCH] xen/pci: Fix build on non-x86 Ben Hutchings
2014-01-02 11:50 ` David Vrabel
2014-01-06 9:58 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.