Re: [PATCH] drm/radeon: Disable writeback by default on ppc

[Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>]

On 12/10/2013 01:12 PM, Alex Deucher wrote:
> On Tue, Dec 10, 2013 at 10:04 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
>> On Mon, Dec 9, 2013 at 9:20 PM, Michel Dänzer <michel@daenzer.net> wrote:
>>> On Mon, 2013-12-09 at 19:48 -0500, Alex Deucher wrote:
>>>>
>>>> -u32 cik_compute_ring_get_wptr(struct radeon_device *rdev,
>>>> -                             struct radeon_ring *ring)
>>>> +u32 cik_compute_get_wptr(struct radeon_device *rdev,
>>>> +                        struct radeon_ring *ring)
>>>>   {
>>>>          u32 wptr;
>>>>
>>>>          if (rdev->wb.enabled) {
>>>> -               wptr = le32_to_cpu(rdev->wb.wb[ring->wptr_offs/4]);
>>>> +               wptr = rdev->wb.wb[ring->wptr_offs/4];
>>>>          } else {
>>>>                  mutex_lock(&rdev->srbm_mutex);
>>>>                  cik_srbm_select(rdev, ring->me, ring->pipe,
>>>> ring->queue, 0);
>>>> @@ -4053,8 +4081,8 @@ u32 cik_compute_ring_get_wptr(struct
>>>> radeon_device *rdev,
>>>>          return wptr;
>>>>   }
>>>>
>>>> -void cik_compute_ring_set_wptr(struct radeon_device *rdev,
>>>> -                              struct radeon_ring *ring)
>>>> +void cik_compute_set_wptr(struct radeon_device *rdev,
>>>> +                         struct radeon_ring *ring)
>>>>   {
>>>>          rdev->wb.wb[ring->wptr_offs/4] = cpu_to_le32(ring->wptr);
>>>
>>> I think this cpu_to_le32() needs to be dropped as well to match
>>> cik_compute_ring_get_wptr().
>>
>> whoops, yeah, missed that one.
>
> Updated patch attached.
>
> Alex
>

Hi, Alex.

Has this patch been accepted upstream? I've tested it successfully on a 
ppc64 system with a FirePro 2270 adapter.


Thanks,


-- 
Kleber Sacilotto de Souza
IBM Linux Technology Center