From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joe Perches <joe@perches.com>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: coding style fixes
Date: Fri, 03 Jan 2014 09:52:45 +0000 [thread overview]
Message-ID: <52C6886D.2000801@cogentembedded.com> (raw)
In-Reply-To: <1388713347.2259.86.camel@joe-AO722>
Hello.
On 03-01-2014 5:42, Joe Perches wrote:
>>> @@ -1952,8 +1949,8 @@ static void sh_eth_tx_timeout(struct net
>>> netif_stop_queue(ndev);
>>>
>>> if (netif_msg_timer(mdp))
>>> - dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x,"
>>> - " resetting...\n", ndev->name, (int)sh_eth_read(ndev, EESR));
>>> + dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x, resetting...\n"
>>> + ndev->name, (int)sh_eth_read(ndev, EESR));
>>>
>>> /* tx_errors count up */
>>> ndev->stats.tx_errors++;
>> You did not build test this.
>> drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_tx_timeout’:
>> drivers/net/ethernet/renesas/sh_eth.c:1953:4: error: expected ‘)’ before ‘ndev’
> Also, this would likely be better as:
>
> netif_err(mdp, timer, ndev, "transmit timed out, status %#08lx, resetting...\n",
> sh_eth_read(ndev, EESR));
If checkpoint.pl did point this out, I would have fixed it. Since it
doesn't, it's probably material of another patch.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joe Perches <joe@perches.com>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: coding style fixes
Date: Fri, 03 Jan 2014 13:52:45 +0400 [thread overview]
Message-ID: <52C6886D.2000801@cogentembedded.com> (raw)
In-Reply-To: <1388713347.2259.86.camel@joe-AO722>
Hello.
On 03-01-2014 5:42, Joe Perches wrote:
>>> @@ -1952,8 +1949,8 @@ static void sh_eth_tx_timeout(struct net
>>> netif_stop_queue(ndev);
>>>
>>> if (netif_msg_timer(mdp))
>>> - dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x,"
>>> - " resetting...\n", ndev->name, (int)sh_eth_read(ndev, EESR));
>>> + dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x, resetting...\n"
>>> + ndev->name, (int)sh_eth_read(ndev, EESR));
>>>
>>> /* tx_errors count up */
>>> ndev->stats.tx_errors++;
>> You did not build test this.
>> drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_tx_timeout’:
>> drivers/net/ethernet/renesas/sh_eth.c:1953:4: error: expected ‘)’ before ‘ndev’
> Also, this would likely be better as:
>
> netif_err(mdp, timer, ndev, "transmit timed out, status %#08lx, resetting...\n",
> sh_eth_read(ndev, EESR));
If checkpoint.pl did point this out, I would have fixed it. Since it
doesn't, it's probably material of another patch.
WBR, Sergei
next prev parent reply other threads:[~2014-01-03 9:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 23:25 [PATCH] sh_eth: coding style fixes Sergei Shtylyov
2013-12-31 0:25 ` Sergei Shtylyov
2014-01-03 0:34 ` David Miller
2014-01-03 0:34 ` David Miller
2014-01-03 1:42 ` Joe Perches
2014-01-03 1:42 ` Joe Perches
2014-01-03 9:52 ` Sergei Shtylyov [this message]
2014-01-03 9:52 ` Sergei Shtylyov
2014-01-03 14:28 ` Joe Perches
2014-01-03 14:28 ` Joe Perches
2014-01-03 9:50 ` Sergei Shtylyov
2014-01-03 9:50 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C6886D.2000801@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.