From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 4/6] phy: kill excess code
Date: Sat, 04 Jan 2014 19:29:35 +0300 [thread overview]
Message-ID: <52C836EF.1010705@cogentembedded.com> (raw)
In-Reply-To: <20140104073639.GB4261@netboy>
Hello.
On 01/04/2014 10:36 AM, Richard Cochran wrote:
>> Remove tens of lines of unnecessary code:
>> - kill empty lines between a function call and its result check;
> ...
>> - kill excess empty lines.
> Blank lines are not LOC. They can improve legibility.
Both kinds of empty lines are consistently avoided by all other code I had
to read. They don't really improve anything.
> Thanks,
> Richard
WBR, Sergei
next prev parent reply other threads:[~2014-01-04 15:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 1:13 [PATCH 0/6] phylib: cleanups Sergei Shtylyov
2014-01-04 1:14 ` [PATCH 1/6] phy: coding style fixes Sergei Shtylyov
2014-01-04 1:16 ` [PATCH 2/6] mdio_bus: " Sergei Shtylyov
2014-01-04 1:17 ` [PATCH 3/6] phy: kill useless local variables Sergei Shtylyov
2014-01-04 7:34 ` Richard Cochran
2014-01-04 1:19 ` [PATCH 4/6] phy: kill excess code Sergei Shtylyov
2014-01-04 7:36 ` Richard Cochran
2014-01-04 16:29 ` Sergei Shtylyov [this message]
2014-01-04 15:42 ` Richard Cochran
2014-01-04 16:47 ` Sergei Shtylyov
2014-01-04 15:51 ` Richard Cochran
2014-01-05 0:50 ` Sergei Shtylyov
[not found] ` <CAGVrzcadLFE-FWvgDQE5gkd6COZkGs2Q4SQdnOdKE4Deu-qa0A@mail.gmail.com>
2014-01-04 16:24 ` Sergei Shtylyov
2014-01-04 1:21 ` [PATCH 5/6] phylib: remove unused adjust_state callback Sergei Shtylyov
2014-01-04 1:23 ` [PATCH 6/6] phylib: make phy_scan_fixups() static Sergei Shtylyov
2014-01-05 0:07 ` Sergei Shtylyov
2014-01-04 1:28 ` [PATCH 0/6] phylib: cleanups Sergei Shtylyov
2014-01-04 15:53 ` Richard Cochran
2014-01-04 17:14 ` Sergei Shtylyov
2014-01-04 18:53 ` Sergei Shtylyov
2014-01-05 8:31 ` Richard Cochran
2014-01-05 13:40 ` Sergei Shtylyov
2014-01-06 8:35 ` Richard Cochran
2014-01-04 16:41 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C836EF.1010705@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.