From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/6] phylib: cleanups
Date: Sun, 05 Jan 2014 17:40:08 +0400 [thread overview]
Message-ID: <52C960B8.1020607@cogentembedded.com> (raw)
In-Reply-To: <20140105083109.GB4933@netboy>
On 05-01-2014 12:31, Richard Cochran wrote:
>>> Because get_maintainer.pl doesn't suggest it and because Andy Fleming
>>> seems no longer interested in maintaining his code written back in 2004.
> It never hurts to ask.
I would have probably asked if there were not so many obstacles to doing that.
> Your patches are saying, "Andy, your code has poor style."
It's coming back from 2004, so maybe the style wasn't considered bad at
that time...
> I don't
> agree, especially about #3.
It's your right. However, v2 of the patchset has been applied already.
> Also, maybe the deleted callback will
> useful one day.
We kept it for almost 10 years and it never got useful. As I understood
DaveM's policy it is "we don't keep unused stuff".
> After all, there are not that many phylib drivers.
Really? I find the number to be intimidating enough to not do the cleanups
on them also in this same patchset. Anyway, the callback was intended for the
Ethernet drivers.
> Perhaps future MAC drivers will need this.
We can always add it back in that case. However, phy_start_machine() which
is the only way to set the callback was not even exported, so not generally
usable for the MAC drivers. I guess this facility wasn't well thought out from
the start.
>> Besides, I don't have his current email address (the source code
>> doesn't provide any).
> Here, let me find that for you.
Thanks I found those eventually. However, my LinkedIn account told me that
Andy left Freescale about that time (it also gave up his private email though).
> Thanks,
> Richard
WBR, Sergei
next prev parent reply other threads:[~2014-01-05 13:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 1:13 [PATCH 0/6] phylib: cleanups Sergei Shtylyov
2014-01-04 1:14 ` [PATCH 1/6] phy: coding style fixes Sergei Shtylyov
2014-01-04 1:16 ` [PATCH 2/6] mdio_bus: " Sergei Shtylyov
2014-01-04 1:17 ` [PATCH 3/6] phy: kill useless local variables Sergei Shtylyov
2014-01-04 7:34 ` Richard Cochran
2014-01-04 1:19 ` [PATCH 4/6] phy: kill excess code Sergei Shtylyov
2014-01-04 7:36 ` Richard Cochran
2014-01-04 16:29 ` Sergei Shtylyov
2014-01-04 15:42 ` Richard Cochran
2014-01-04 16:47 ` Sergei Shtylyov
2014-01-04 15:51 ` Richard Cochran
2014-01-05 0:50 ` Sergei Shtylyov
[not found] ` <CAGVrzcadLFE-FWvgDQE5gkd6COZkGs2Q4SQdnOdKE4Deu-qa0A@mail.gmail.com>
2014-01-04 16:24 ` Sergei Shtylyov
2014-01-04 1:21 ` [PATCH 5/6] phylib: remove unused adjust_state callback Sergei Shtylyov
2014-01-04 1:23 ` [PATCH 6/6] phylib: make phy_scan_fixups() static Sergei Shtylyov
2014-01-05 0:07 ` Sergei Shtylyov
2014-01-04 1:28 ` [PATCH 0/6] phylib: cleanups Sergei Shtylyov
2014-01-04 15:53 ` Richard Cochran
2014-01-04 17:14 ` Sergei Shtylyov
2014-01-04 18:53 ` Sergei Shtylyov
2014-01-05 8:31 ` Richard Cochran
2014-01-05 13:40 ` Sergei Shtylyov [this message]
2014-01-06 8:35 ` Richard Cochran
2014-01-04 16:41 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C960B8.1020607@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.