From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Karim Raslan <karim.allah.ahmed@gmail.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] enable/disable dom0_11_mapping from command-line and default to enabled
Date: Sun, 05 Jan 2014 20:15:49 +0000 [thread overview]
Message-ID: <52C9BD75.6070207@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1401051923590.8667@kaball.uk.xensource.com>
On 01/05/2014 07:24 PM, Stefano Stabellini wrote:
> On Sun, 5 Jan 2014, Karim Raslan wrote:
>> Signed-off-by: Karim Raslan <karim.allah.ahmed@gmail.com>
>
> Thanks!
> Given that dom0_11_mapping is an int, the patch is OK.
> However it might be better to turn dom0_11_mapping into a bool_t and use
> boolean_param instead.
After reading the thread "Master not working on AllWinner A20", I still
don't see why this patch is useful.
Unless if the platform has an IOMMU, the 1:1 mapping for the memory
SHOULD be enabled. Otherwise DMA-capable won't work.
See my answer on your mail (thread "Master not working on AllWinner for
A20") for a proper fix.
--
Julien Grall
next prev parent reply other threads:[~2014-01-05 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 19:21 [PATCH] enable/disable dom0_11_mapping from command-line and default to enabled Karim Raslan
2014-01-05 19:24 ` Stefano Stabellini
2014-01-05 20:15 ` Julien Grall [this message]
2014-01-06 11:12 ` Stefano Stabellini
2014-01-06 11:15 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C9BD75.6070207@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=karim.allah.ahmed@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.