All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
To: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
Cc: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org,
	Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] xfstests: fix wrong return check for case 022
Date: Mon, 06 Jan 2014 17:23:14 +0900	[thread overview]
Message-ID: <52CA67F2.9010108@jp.fujitsu.com> (raw)
In-Reply-To: <1388995737-3480-1-git-send-email-wangsl.fnst@cn.fujitsu.com>

On 2014/01/06 17:08, Wang Shilong wrote:
> Here we expect 0 as return value, fix it.
> 
> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
> Cc: Josef Bacik <jbacik@fb.com>
> ---
>   tests/btrfs/022 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>   mode change 100644 => 100755 tests/btrfs/022
> 
> diff --git a/tests/btrfs/022 b/tests/btrfs/022
> old mode 100644
> new mode 100755
> index 5b18643..142aaf9
> --- a/tests/btrfs/022
> +++ b/tests/btrfs/022
> @@ -106,7 +106,7 @@ _limit_test()
>   	[ $? -ne 0 ] || _fail "quota should have limited us"
>   	dd if=/dev/urandom of=$SCRATCH_MNT/a/file bs=4M count=1 >> \
>   		$seqres.full 2>&1
> -	[ $? -eq 0 ] || _fail "should have been allowed to write"
> +	[ $? -ne 0 ] || _fail "should have been allowed to write"

from "man bash",
       An OR list has the form
              command1 || command2
       command2 is executed if and only if command1 returns a non-zero exit
       status.

So, original code is OK, I think.

Thanks,
Tsutomu

>   }
>   
>   _scratch_mkfs > /dev/null 2>&1
> 



WARNING: multiple messages have this Message-ID (diff)
From: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
To: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
Cc: Josef Bacik <jbacik@fb.com>,
	linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix wrong return check for case 022
Date: Mon, 06 Jan 2014 17:23:14 +0900	[thread overview]
Message-ID: <52CA67F2.9010108@jp.fujitsu.com> (raw)
In-Reply-To: <1388995737-3480-1-git-send-email-wangsl.fnst@cn.fujitsu.com>

On 2014/01/06 17:08, Wang Shilong wrote:
> Here we expect 0 as return value, fix it.
> 
> Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
> Cc: Josef Bacik <jbacik@fb.com>
> ---
>   tests/btrfs/022 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>   mode change 100644 => 100755 tests/btrfs/022
> 
> diff --git a/tests/btrfs/022 b/tests/btrfs/022
> old mode 100644
> new mode 100755
> index 5b18643..142aaf9
> --- a/tests/btrfs/022
> +++ b/tests/btrfs/022
> @@ -106,7 +106,7 @@ _limit_test()
>   	[ $? -ne 0 ] || _fail "quota should have limited us"
>   	dd if=/dev/urandom of=$SCRATCH_MNT/a/file bs=4M count=1 >> \
>   		$seqres.full 2>&1
> -	[ $? -eq 0 ] || _fail "should have been allowed to write"
> +	[ $? -ne 0 ] || _fail "should have been allowed to write"

from "man bash",
       An OR list has the form
              command1 || command2
       command2 is executed if and only if command1 returns a non-zero exit
       status.

So, original code is OK, I think.

Thanks,
Tsutomu

>   }
>   
>   _scratch_mkfs > /dev/null 2>&1
> 


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-01-06  8:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06  8:08 [PATCH] xfstests: fix wrong return check for case 022 Wang Shilong
2014-01-06  8:08 ` Wang Shilong
2014-01-06  8:23 ` Tsutomu Itoh [this message]
2014-01-06  8:23   ` Tsutomu Itoh
2014-01-06  8:48   ` Wang Shilong
2014-01-06  8:48     ` Wang Shilong
2014-01-07  1:11     ` Tsutomu Itoh
2014-01-07  1:11       ` Tsutomu Itoh
2014-01-07  2:19       ` Wang Shilong
2014-01-07  2:19         ` Wang Shilong
2014-01-07  3:24         ` Tsutomu Itoh
2014-01-07  3:24           ` Tsutomu Itoh
2014-01-07  3:48           ` Wang Shilong
2014-01-07  3:48             ` Wang Shilong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CA67F2.9010108@jp.fujitsu.com \
    --to=t-itoh@jp.fujitsu.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wangsl.fnst@cn.fujitsu.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.