From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mfd: always assign of_node in mfd_add_device()
Date: Mon, 06 Jan 2014 11:12:15 -0700 [thread overview]
Message-ID: <52CAF1FF.9090709@wwwdotorg.org> (raw)
In-Reply-To: <20131220142530.GK3709@lee--X1>
On 12/20/2013 07:25 AM, Lee Jones wrote:
> Hi Stephen,
>
> Please let me know if this is suitable and I can keep your Ack.
This patch doesn't seem to have made it into next-20140106. I assume
that's just because of the holidays, not because it was forgotten?
> ----
>
> mfd: Revert "mfd: Always assign of_node in mfd_add_device()"
>
> This reverts commit 68044bee13770918e0b28dd44aa98c889ec7558f.
>
> We've had confirmed reports of this patch causing unforeseen issues
> with existing MFD users. It has been agreed by the original author
> and myself that reversion is the best solution.
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 32e8d47..2676492 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -117,8 +117,6 @@ static int mfd_add_device(struct device *parent, int id,
> }
> }
> }
> - if (!pdev->dev.of_node)
> - pdev->dev.of_node = parent->of_node;
>
> if (cell->pdata_size) {
> ret = platform_device_add_data(pdev,
>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/3] mfd: always assign of_node in mfd_add_device()
Date: Mon, 06 Jan 2014 11:12:15 -0700 [thread overview]
Message-ID: <52CAF1FF.9090709@wwwdotorg.org> (raw)
In-Reply-To: <20131220142530.GK3709@lee--X1>
On 12/20/2013 07:25 AM, Lee Jones wrote:
> Hi Stephen,
>
> Please let me know if this is suitable and I can keep your Ack.
This patch doesn't seem to have made it into next-20140106. I assume
that's just because of the holidays, not because it was forgotten?
> ----
>
> mfd: Revert "mfd: Always assign of_node in mfd_add_device()"
>
> This reverts commit 68044bee13770918e0b28dd44aa98c889ec7558f.
>
> We've had confirmed reports of this patch causing unforeseen issues
> with existing MFD users. It has been agreed by the original author
> and myself that reversion is the best solution.
>
> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 32e8d47..2676492 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -117,8 +117,6 @@ static int mfd_add_device(struct device *parent, int id,
> }
> }
> }
> - if (!pdev->dev.of_node)
> - pdev->dev.of_node = parent->of_node;
>
> if (cell->pdata_size) {
> ret = platform_device_add_data(pdev,
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-06 18:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 22:06 [PATCH 1/3] mfd: always assign of_node in mfd_add_device() Stephen Warren
2013-12-09 22:06 ` Stephen Warren
2013-12-09 22:06 ` [PATCH 2/3] rtc: honor device tree /alias entries when assigning IDs Stephen Warren
2013-12-09 22:06 ` Stephen Warren
2013-12-09 22:06 ` [PATCH 3/3] ARM: tegra: set up /aliases entries for RTCs Stephen Warren
2013-12-09 22:06 ` Stephen Warren
2013-12-10 8:40 ` [PATCH 1/3] mfd: always assign of_node in mfd_add_device() Lee Jones
2013-12-10 8:40 ` Lee Jones
2013-12-10 16:54 ` Stephen Warren
2013-12-10 16:54 ` Stephen Warren
2013-12-11 9:24 ` Lee Jones
2013-12-11 9:24 ` Lee Jones
2013-12-13 19:28 ` Stephen Warren
2013-12-13 19:28 ` Stephen Warren
2013-12-16 8:12 ` Lee Jones
2013-12-16 8:12 ` Lee Jones
2013-12-19 17:25 ` Stephen Warren
2013-12-19 17:25 ` Stephen Warren
2013-12-20 14:20 ` Lee Jones
2013-12-20 14:20 ` Lee Jones
2013-12-20 14:25 ` Lee Jones
2013-12-20 14:25 ` Lee Jones
2013-12-20 16:11 ` Stephen Warren
2013-12-20 16:11 ` Stephen Warren
2014-01-06 18:12 ` Stephen Warren [this message]
2014-01-06 18:12 ` Stephen Warren
2014-01-07 8:23 ` Lee Jones
2014-01-07 8:23 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CAF1FF.9090709@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.