From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel
Date: Mon, 06 Jan 2014 13:07:26 -0700 [thread overview]
Message-ID: <52CB0CFE.4070901@wwwdotorg.org> (raw)
In-Reply-To: <1387891931-9854-2-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 12/24/2013 06:32 AM, Peter De Schrijver wrote:
> Export APB DMA readl and writel. These are needed because we can't access
> the fuses directly on Tegra20 without potentially causing a system hang.
This does a lot more than just export the functions; it also changes the
prototypes. I'm not sure why the prototype change was required/useful.
This needs to be mentioned in the commit description/subject, and the
reasoning explained too.
> diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h
> +#if defined(CONFIG_TEGRA20_APB_DMA)
> +void tegra_apb_io_init(void);
This seems to be an internal function; why is this one publicly
prototyped and/or stubbed?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel
Date: Mon, 06 Jan 2014 13:07:26 -0700 [thread overview]
Message-ID: <52CB0CFE.4070901@wwwdotorg.org> (raw)
In-Reply-To: <1387891931-9854-2-git-send-email-pdeschrijver@nvidia.com>
On 12/24/2013 06:32 AM, Peter De Schrijver wrote:
> Export APB DMA readl and writel. These are needed because we can't access
> the fuses directly on Tegra20 without potentially causing a system hang.
This does a lot more than just export the functions; it also changes the
prototypes. I'm not sure why the prototype change was required/useful.
This needs to be mentioned in the commit description/subject, and the
reasoning explained too.
> diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h
> +#if defined(CONFIG_TEGRA20_APB_DMA)
> +void tegra_apb_io_init(void);
This seems to be an internal function; why is this one publicly
prototyped and/or stubbed?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Hiroshi Doyu <hdoyu@nvidia.com>, Wolfram Sang <wsa@the-dreams.de>,
Prashant Gaikwad <pgaikwad@nvidia.com>
Subject: Re: [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel
Date: Mon, 06 Jan 2014 13:07:26 -0700 [thread overview]
Message-ID: <52CB0CFE.4070901@wwwdotorg.org> (raw)
In-Reply-To: <1387891931-9854-2-git-send-email-pdeschrijver@nvidia.com>
On 12/24/2013 06:32 AM, Peter De Schrijver wrote:
> Export APB DMA readl and writel. These are needed because we can't access
> the fuses directly on Tegra20 without potentially causing a system hang.
This does a lot more than just export the functions; it also changes the
prototypes. I'm not sure why the prototype change was required/useful.
This needs to be mentioned in the commit description/subject, and the
reasoning explained too.
> diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h
> +#if defined(CONFIG_TEGRA20_APB_DMA)
> +void tegra_apb_io_init(void);
This seems to be an internal function; why is this one publicly
prototyped and/or stubbed?
next prev parent reply other threads:[~2014-01-06 20:07 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 13:32 [PATCH v2 0/6] efuse driver for Tegra Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
[not found] ` <1387891931-9854-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-24 13:32 ` [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
[not found] ` <1387891931-9854-2-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-06 20:07 ` Stephen Warren [this message]
2014-01-06 20:07 ` Stephen Warren
2014-01-06 20:07 ` Stephen Warren
[not found] ` <52CB0CFE.4070901-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-07 12:54 ` Peter De Schrijver
2014-01-07 12:54 ` Peter De Schrijver
2014-01-07 12:54 ` Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 4/6] ARM: tegra: rework fuse.c Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2014-01-03 11:19 ` Alexandre Courbot
2014-01-03 11:19 ` Alexandre Courbot
2014-01-03 11:19 ` Alexandre Courbot
[not found] ` <1387891931-9854-5-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-06 20:50 ` Stephen Warren
2014-01-06 20:50 ` Stephen Warren
2014-01-06 20:50 ` Stephen Warren
[not found] ` <52CB1722.70306-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-07 14:10 ` Peter De Schrijver
2014-01-07 14:10 ` Peter De Schrijver
2014-01-07 14:10 ` Peter De Schrijver
[not found] ` <20140107141004.GF26588-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-01-07 20:47 ` Stephen Warren
2014-01-07 20:47 ` Stephen Warren
2014-01-07 20:47 ` Stephen Warren
[not found] ` <52CC67C9.9000704-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-08 8:31 ` Peter De Schrijver
2014-01-08 8:31 ` Peter De Schrijver
2014-01-08 8:31 ` Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 2/6] misc: fuse: Add efuse driver for Tegra Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2014-01-06 20:32 ` Stephen Warren
2014-01-06 20:32 ` Stephen Warren
[not found] ` <52CB12D8.7000203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-07 14:05 ` Peter De Schrijver
2014-01-07 14:05 ` Peter De Schrijver
2014-01-07 14:05 ` Peter De Schrijver
[not found] ` <20140107140502.GE26588-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-01-07 20:41 ` Stephen Warren
2014-01-07 20:41 ` Stephen Warren
2014-01-07 20:41 ` Stephen Warren
2013-12-24 13:32 ` [PATCH v2 3/6] ARM: tegra: Add efuse bindings Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
[not found] ` <1387891931-9854-4-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-06 20:40 ` Stephen Warren
2014-01-06 20:40 ` Stephen Warren
2014-01-06 20:40 ` Stephen Warren
[not found] ` <52CB14D3.2060904-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-08 13:39 ` Thierry Reding
2014-01-08 13:39 ` Thierry Reding
2014-01-08 13:39 ` Thierry Reding
[not found] ` <20140108133951.GD1592-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-01-08 18:50 ` Stephen Warren
2014-01-08 18:50 ` Stephen Warren
2014-01-08 18:50 ` Stephen Warren
[not found] ` <52CD9DFB.9010007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-08 20:05 ` Thierry Reding
2014-01-08 20:05 ` Thierry Reding
2014-01-08 20:05 ` Thierry Reding
2014-01-08 20:09 ` Thierry Reding
2014-01-08 20:09 ` Thierry Reding
2014-01-08 20:09 ` Thierry Reding
[not found] ` <20140108200946.GE1298-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-01-08 22:41 ` Stephen Warren
2014-01-08 22:41 ` Stephen Warren
2014-01-08 22:41 ` Stephen Warren
[not found] ` <52CDD430.3010508-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-09 12:40 ` Thierry Reding
2014-01-09 12:40 ` Thierry Reding
2014-01-09 12:40 ` Thierry Reding
2013-12-24 13:32 ` [PATCH v2 5/6] ARM: Tegra: remove speedo files Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 6/6] misc: enable fuse drivers Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
2013-12-24 13:32 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CB0CFE.4070901@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.