All of lore.kernel.org
 help / color / mirror / Atom feed
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] phy: kconfig: add depends on "USB_PHY" to OMAP_USB2 and TWL4030_USB
Date: Tue, 7 Jan 2014 15:23:35 +0530	[thread overview]
Message-ID: <52CBCE9F.7040908@ti.com> (raw)
In-Reply-To: <20131226130504.GA19462@blackmetal.musicnaut.iki.fi>

On Thursday 26 December 2013 06:35 PM, Aaro Koskinen wrote:
> Hi,
> 
> On Tue, Dec 03, 2013 at 07:38:52PM +0530, Kishon Vijay Abraham I wrote:
>> Fixes
>> warning: (OMAP_USB2 && TWL4030_USB) selects USB_PHY which has unmet
>> direct dependencies (USB_SUPPORT)
>> that shows up while disabling USB_SUPPORT from menuconfig.
> [...]
>>  config TWL4030_USB
>>  	tristate "TWL4030 USB Transceiver Driver"
>>  	depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS
>> +	depends on USB_PHY
>>  	select GENERIC_PHY
>> -	select USB_PHY
>>  	help
>>  	  Enable this to support the USB OTG transceiver on TWL4030
>>  	  family chips (including the TWL5030 and TPS659x0 devices).
> 
> This introduced a minor problem in 3.13-rc5: User is no longer able to
> select TWL4030_USB with menuconfig, since there is no menu entry for
> enabling USB_PHY. The only way to enable TWL4030_USB is to enable some
> other option first that happens to select USB_PHY...

huh.. I think we should go back to my v1 [1] or make USB_PHY selectable. I'm
not sure if there is any other way to handle this.

Thanks
Kishon

[1] -> https://groups.google.com/forum/#!topic/linux.kernel/Omf83s4rkwY
> 
> A.
> 

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: <balbi@ti.com>, <linux@arm.linux.org.uk>,
	<gregkh@linuxfoundation.org>, <santosh.shilimkar@ti.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] phy: kconfig: add depends on "USB_PHY" to OMAP_USB2 and TWL4030_USB
Date: Tue, 7 Jan 2014 15:23:35 +0530	[thread overview]
Message-ID: <52CBCE9F.7040908@ti.com> (raw)
In-Reply-To: <20131226130504.GA19462@blackmetal.musicnaut.iki.fi>

On Thursday 26 December 2013 06:35 PM, Aaro Koskinen wrote:
> Hi,
> 
> On Tue, Dec 03, 2013 at 07:38:52PM +0530, Kishon Vijay Abraham I wrote:
>> Fixes
>> warning: (OMAP_USB2 && TWL4030_USB) selects USB_PHY which has unmet
>> direct dependencies (USB_SUPPORT)
>> that shows up while disabling USB_SUPPORT from menuconfig.
> [...]
>>  config TWL4030_USB
>>  	tristate "TWL4030 USB Transceiver Driver"
>>  	depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS
>> +	depends on USB_PHY
>>  	select GENERIC_PHY
>> -	select USB_PHY
>>  	help
>>  	  Enable this to support the USB OTG transceiver on TWL4030
>>  	  family chips (including the TWL5030 and TPS659x0 devices).
> 
> This introduced a minor problem in 3.13-rc5: User is no longer able to
> select TWL4030_USB with menuconfig, since there is no menu entry for
> enabling USB_PHY. The only way to enable TWL4030_USB is to enable some
> other option first that happens to select USB_PHY...

huh.. I think we should go back to my v1 [1] or make USB_PHY selectable. I'm
not sure if there is any other way to handle this.

Thanks
Kishon

[1] -> https://groups.google.com/forum/#!topic/linux.kernel/Omf83s4rkwY
> 
> A.
> 


  reply	other threads:[~2014-01-07  9:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 14:08 [PATCH v2] phy: kconfig: add depends on "USB_PHY" to OMAP_USB2 and TWL4030_USB Kishon Vijay Abraham I
2013-12-03 14:08 ` Kishon Vijay Abraham I
2013-12-26 13:05 ` Aaro Koskinen
2013-12-26 13:05   ` Aaro Koskinen
2014-01-07  9:53   ` Kishon Vijay Abraham I [this message]
2014-01-07  9:53     ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CBCE9F.7040908@ti.com \
    --to=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.