All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep.Holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cache-l2x0: Parse properties from DT for PL310 cache controller
Date: Tue, 07 Jan 2014 12:41:42 +0000	[thread overview]
Message-ID: <52CBF606.5080209@arm.com> (raw)
In-Reply-To: <1389094888-24348-1-git-send-email-tushar.behera@linaro.org>

On 07/01/14 11:41, Tushar Behera wrote:
> Parsed auxiliary control properties for PL310 cache controller.
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> These properties are set for Exynos4 platform. If we can pass these properties
> through device tree for Exynos4, then we can remove the hard-coded L2_AUX_VAL.
> 
>  Documentation/devicetree/bindings/arm/l2cc.txt |   10 ++++++++++
>  arch/arm/include/asm/hardware/cache-l2x0.h     |    1 +
>  arch/arm/mm/cache-l2x0.c                       |   25 ++++++++++++++++++++++++
>  3 files changed, 36 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/l2cc.txt b/Documentation/devicetree/bindings/arm/l2cc.txt
> index b513cb8..213546d 100644
> --- a/Documentation/devicetree/bindings/arm/l2cc.txt
> +++ b/Documentation/devicetree/bindings/arm/l2cc.txt
> @@ -44,6 +44,16 @@ Optional properties:
>  - cache-id-part: cache id part number to be used if it is not present
>    on hardware
>  - wt-override: If present then L2 is forced to Write through mode
> +- arm,early-write: If present then BRSEP mode (early write response) is enabled.
> +- arm,data-prefetch: If present then data prefetching is enabled.
> +- arm,instruction-prefetch: If present then instruction prefetching is enabled.
> +- arm,ns-interrupt-access: If present then interrupt mask and interrupt clear
> +  registers can be read or modified in both secure or non-secure accesses.
> +- arm,ns-lockdown: If present then non-secure accesses can write to lockdown
> +  register.
> +- arm,share-override: If present then shared attribute is ignored internally.
> +- arm,full-line-of-zero: If present then 'full line of write zero' behaviour is
> +  enabled.
>  
Hi Tushar,

This has been discussed couple of times in past[1][2], and the opinion was not
to have these in DT as they are more configuration data than the actual hardware
description.

Regards,
Sudeep

[1] https://lkml.org/lkml/2013/11/7/8
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-July/185610.html

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <Sudeep.Holla@arm.com>
To: Tushar Behera <tushar.behera@linaro.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: Sudeep.Holla@arm.com,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH] ARM: cache-l2x0: Parse properties from DT for PL310 cache controller
Date: Tue, 07 Jan 2014 12:41:42 +0000	[thread overview]
Message-ID: <52CBF606.5080209@arm.com> (raw)
In-Reply-To: <1389094888-24348-1-git-send-email-tushar.behera@linaro.org>

On 07/01/14 11:41, Tushar Behera wrote:
> Parsed auxiliary control properties for PL310 cache controller.
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> These properties are set for Exynos4 platform. If we can pass these properties
> through device tree for Exynos4, then we can remove the hard-coded L2_AUX_VAL.
> 
>  Documentation/devicetree/bindings/arm/l2cc.txt |   10 ++++++++++
>  arch/arm/include/asm/hardware/cache-l2x0.h     |    1 +
>  arch/arm/mm/cache-l2x0.c                       |   25 ++++++++++++++++++++++++
>  3 files changed, 36 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/l2cc.txt b/Documentation/devicetree/bindings/arm/l2cc.txt
> index b513cb8..213546d 100644
> --- a/Documentation/devicetree/bindings/arm/l2cc.txt
> +++ b/Documentation/devicetree/bindings/arm/l2cc.txt
> @@ -44,6 +44,16 @@ Optional properties:
>  - cache-id-part: cache id part number to be used if it is not present
>    on hardware
>  - wt-override: If present then L2 is forced to Write through mode
> +- arm,early-write: If present then BRSEP mode (early write response) is enabled.
> +- arm,data-prefetch: If present then data prefetching is enabled.
> +- arm,instruction-prefetch: If present then instruction prefetching is enabled.
> +- arm,ns-interrupt-access: If present then interrupt mask and interrupt clear
> +  registers can be read or modified in both secure or non-secure accesses.
> +- arm,ns-lockdown: If present then non-secure accesses can write to lockdown
> +  register.
> +- arm,share-override: If present then shared attribute is ignored internally.
> +- arm,full-line-of-zero: If present then 'full line of write zero' behaviour is
> +  enabled.
>  
Hi Tushar,

This has been discussed couple of times in past[1][2], and the opinion was not
to have these in DT as they are more configuration data than the actual hardware
description.

Regards,
Sudeep

[1] https://lkml.org/lkml/2013/11/7/8
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-July/185610.html



  parent reply	other threads:[~2014-01-07 12:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 11:41 [PATCH] ARM: cache-l2x0: Parse properties from DT for PL310 cache controller Tushar Behera
2014-01-07 11:41 ` Tushar Behera
2014-01-07 11:57 ` Arnd Bergmann
2014-01-07 11:57   ` Arnd Bergmann
2014-01-07 12:10   ` Tushar Behera
2014-01-07 12:10     ` Tushar Behera
2014-01-07 12:41 ` Sudeep Holla [this message]
2014-01-07 12:41   ` Sudeep Holla
2014-01-07 12:54   ` Arnd Bergmann
2014-01-07 12:54     ` Arnd Bergmann
2014-01-07 15:55     ` Sudeep Holla
2014-01-07 15:55       ` Sudeep Holla
2014-01-07 16:12       ` Arnd Bergmann
2014-01-07 16:12         ` Arnd Bergmann
2014-01-07 16:43         ` Sudeep Holla
2014-01-07 16:43           ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CBF606.5080209@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.