From: "Christian König" <deathsimple@vodafone.de>
To: Alex Deucher <alexdeucher@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>, stable@vger.kernel.org
Subject: Re: [PATCH] drm/radeon: warn users when hw_i2c is enabled
Date: Tue, 07 Jan 2014 16:16:00 +0100 [thread overview]
Message-ID: <52CC1A30.9020609@vodafone.de> (raw)
In-Reply-To: <1389107665-2952-1-git-send-email-alexander.deucher@amd.com>
Am 07.01.2014 16:14, schrieb Alex Deucher:
> The hw i2c engines are disabled by default as the
> current implementation is still experimental. Print
> a warning when users enable it so that it's obvious
> when the option is enabled.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_i2c.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
> index fc60b74..74bfbf8 100644
> --- a/drivers/gpu/drm/radeon/radeon_i2c.c
> +++ b/drivers/gpu/drm/radeon/radeon_i2c.c
> @@ -1020,6 +1020,9 @@ void radeon_i2c_destroy(struct radeon_i2c_chan *i2c)
> /* Add the default buses */
> void radeon_i2c_init(struct radeon_device *rdev)
> {
> + if (radeon_hw_i2c == 1)
> + DRM_INFO("hw_i2c forced on, you may experience display detection problems!\n");
> +
> if (rdev->is_atom_bios)
> radeon_atombios_i2c_init(rdev);
> else
next prev parent reply other threads:[~2014-01-07 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 15:14 [PATCH] drm/radeon: warn users when hw_i2c is enabled Alex Deucher
2014-01-07 15:16 ` Christian König [this message]
2014-01-07 15:58 ` Grigori Goronzy
2014-01-07 16:02 ` Alex Deucher
2014-01-07 16:16 ` Rafał Miłecki
2014-01-07 16:46 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CC1A30.9020609@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.