All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <khali@linux-fr.org>,
	Eduardo Valentin <eduardo.valentin@ti.com>,
	Zhang Rui <rui.zhang@intel.com>
Cc: LM Sensors <lm-sensors@lm-sensors.org>,
	linux-pm@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] hwmon: Fix SENSORS_TMP102 dependencies to eliminate build errors
Date: Wed, 08 Jan 2014 05:49:56 -0800	[thread overview]
Message-ID: <52CD5784.4060804@roeck-us.net> (raw)
In-Reply-To: <20140108080557.3439ec23@endymion.delvare>

On 01/07/2014 11:05 PM, Jean Delvare wrote:
> Similar to what was done for the lm75 driver.
>
> Add depends on THERMAL since that is what provides the
> register/unregister functions above, but only if THERMAL_OF was
> selected as this is an optional feature of the driver.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Eduardo Valentin <eduardo.valentin@ti.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/hwmon/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-3.13-rc7.orig/drivers/hwmon/Kconfig	2014-01-08 08:00:58.583072658 +0100
> +++ linux-3.13-rc7/drivers/hwmon/Kconfig	2014-01-08 08:01:36.928977997 +0100
> @@ -1285,6 +1285,7 @@ config SENSORS_THMC50
>   config SENSORS_TMP102
>   	tristate "Texas Instruments TMP102"
>   	depends on I2C
> +	depends on THERMAL || !THERMAL_OF
>   	help
>   	  If you say yes here you get support for Texas Instruments TMP102
>   	  sensor chips.
>
>


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <khali@linux-fr.org>,
	Eduardo Valentin <eduardo.valentin@ti.com>,
	Zhang Rui <rui.zhang@intel.com>
Cc: LM Sensors <lm-sensors@lm-sensors.org>,
	linux-pm@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: Fix SENSORS_TMP102 dependencies to eliminate build errors
Date: Wed, 08 Jan 2014 13:49:56 +0000	[thread overview]
Message-ID: <52CD5784.4060804@roeck-us.net> (raw)
In-Reply-To: <20140108080557.3439ec23@endymion.delvare>

On 01/07/2014 11:05 PM, Jean Delvare wrote:
> Similar to what was done for the lm75 driver.
>
> Add depends on THERMAL since that is what provides the
> register/unregister functions above, but only if THERMAL_OF was
> selected as this is an optional feature of the driver.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Eduardo Valentin <eduardo.valentin@ti.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/hwmon/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-3.13-rc7.orig/drivers/hwmon/Kconfig	2014-01-08 08:00:58.583072658 +0100
> +++ linux-3.13-rc7/drivers/hwmon/Kconfig	2014-01-08 08:01:36.928977997 +0100
> @@ -1285,6 +1285,7 @@ config SENSORS_THMC50
>   config SENSORS_TMP102
>   	tristate "Texas Instruments TMP102"
>   	depends on I2C
> +	depends on THERMAL || !THERMAL_OF
>   	help
>   	  If you say yes here you get support for Texas Instruments TMP102
>   	  sensor chips.
>
>


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2014-01-08 13:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08  7:05 [PATCH] hwmon: Fix SENSORS_TMP102 dependencies to eliminate build errors Jean Delvare
2014-01-08  7:05 ` [lm-sensors] " Jean Delvare
2014-01-08 12:20 ` Eduardo Valentin
2014-01-08 12:20   ` [lm-sensors] " Eduardo Valentin
2014-01-08 13:49 ` Guenter Roeck [this message]
2014-01-08 13:49   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CD5784.4060804@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=eduardo.valentin@ti.com \
    --cc=khali@linux-fr.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=rdunlap@infradead.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.