All of lore.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Tejun Heo <tj@kernel.org>, Yinghai Lu <yinghai@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/mm: memblock: switch to use NUMA_NO_NODE
Date: Wed, 8 Jan 2014 13:05:26 -0500	[thread overview]
Message-ID: <52CD9366.2090200@ti.com> (raw)
In-Reply-To: <52CD8A9A.3010608@ti.com>

On Wednesday 08 January 2014 12:27 PM, Grygorii Strashko wrote:
> Hi,
> 
> On 01/08/2014 06:23 PM, Grygorii Strashko wrote:
>> Update X86 code to use NUMA_NO_NODE instead of MAX_NUMNODES while
>> calling memblock APIs, because memblock API is changed to use NUMA_NO_NODE and
>> will produce warning during boot otherwise.
>>
>> See:
>>   https://lkml.org/lkml/2013/12/9/898
>>
> [...]
> 
> or, there are other 3 patches from Sergey Senozhatsky, which actually fix the same warnings:
>  https://lkml.org/lkml/2014/1/6/277 - [PATCH -next] x86 memtest: use NUMA_NO_NODE in do_one_pass()
>  https://lkml.org/lkml/2014/1/6/280 - [PATCH -next] e820: use NUMA_NO_NODE in memblock_find_dma_reserve()
>  http://comments.gmane.org/gmane.linux.kernel/1623429 - [PATCH -next] check: use NUMA_NO_NODE in setup_bios_corruption_check()
> 
Either one should be fine though $subject patch would be my personal preference.

Andrew,
This should kill at least 3 known memblock users with MAX_NUMNODES. Feel
free to pick the patch(s) as per your preference.

Regards,
Santosh




--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Tejun Heo <tj@kernel.org>, Yinghai Lu <yinghai@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/mm: memblock: switch to use NUMA_NO_NODE
Date: Wed, 8 Jan 2014 13:05:26 -0500	[thread overview]
Message-ID: <52CD9366.2090200@ti.com> (raw)
In-Reply-To: <52CD8A9A.3010608@ti.com>

On Wednesday 08 January 2014 12:27 PM, Grygorii Strashko wrote:
> Hi,
> 
> On 01/08/2014 06:23 PM, Grygorii Strashko wrote:
>> Update X86 code to use NUMA_NO_NODE instead of MAX_NUMNODES while
>> calling memblock APIs, because memblock API is changed to use NUMA_NO_NODE and
>> will produce warning during boot otherwise.
>>
>> See:
>>   https://lkml.org/lkml/2013/12/9/898
>>
> [...]
> 
> or, there are other 3 patches from Sergey Senozhatsky, which actually fix the same warnings:
>  https://lkml.org/lkml/2014/1/6/277 - [PATCH -next] x86 memtest: use NUMA_NO_NODE in do_one_pass()
>  https://lkml.org/lkml/2014/1/6/280 - [PATCH -next] e820: use NUMA_NO_NODE in memblock_find_dma_reserve()
>  http://comments.gmane.org/gmane.linux.kernel/1623429 - [PATCH -next] check: use NUMA_NO_NODE in setup_bios_corruption_check()
> 
Either one should be fine though $subject patch would be my personal preference.

Andrew,
This should kill at least 3 known memblock users with MAX_NUMNODES. Feel
free to pick the patch(s) as per your preference.

Regards,
Santosh





  reply	other threads:[~2014-01-08 18:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 13:36 WARNING: CPU: 0 PID: 0 at mm/memblock.c:789 __next_free_mem_range() Fengguang Wu
2014-01-07  2:25 ` [setup_bios_corruption_check] WARNING: CPU: 0 PID: 0 at mm/memblock.c:789 __next_free_mem_range+0x82/0x261() Fengguang Wu
2014-01-08 16:23   ` [PATCH] x86/mm: memblock: switch to use NUMA_NO_NODE Grygorii Strashko
2014-01-08 16:23     ` Grygorii Strashko
2014-01-08 17:27     ` Grygorii Strashko
2014-01-08 17:27       ` Grygorii Strashko
2014-01-08 18:05       ` Santosh Shilimkar [this message]
2014-01-08 18:05         ` Santosh Shilimkar
2014-01-15  1:25     ` David Rientjes
2014-01-15  1:25       ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CD9366.2090200@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=grygorii.strashko@ti.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=rientjes@google.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.