From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read
Date: Sat, 11 Jan 2014 19:35:21 +0100 [thread overview]
Message-ID: <52D18EE9.5030305@gmail.com> (raw)
In-Reply-To: <20140111181432.GB15937@n2100.arm.linux.org.uk>
On 01/11/2014 07:14 PM, Russell King - ARM Linux wrote:
> On Thu, Jan 09, 2014 at 12:04:12PM +0100, Jean-Francois Moine wrote:
>> @@ -1250,6 +1311,39 @@ tda998x_encoder_init(struct i2c_client *client,
>> priv->vip_cntrl_2 = video;
>> }
>>
>> + /* install the optional HDMI connect IRQ */
>> + priv->int_irq = irq_of_parse_and_map(np, 0);
>> + if (priv->int_irq < 0)
>> + priv->int_irq = NO_IRQ;
>> + if (priv->int_irq != NO_IRQ) {
>
> NAK. Do not use NO_IRQ. Use <= 0 instead, or just test against zero for
> no IRQ. It would also be nice to offer this facility to non-DT platforms
> via client->irq. Not every arch in the Linux kernel uses DT.
At least for the DT part, I'd suggest to not ask for interrupt directly
but use a proper gpios property. The can of course be converted to
priv->int_irq in some tda998x_dt_probe.
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Russell King - ARM Linux
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Jean-Francois Moine <moinejf-GANU6spQydw@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read
Date: Sat, 11 Jan 2014 19:35:21 +0100 [thread overview]
Message-ID: <52D18EE9.5030305@gmail.com> (raw)
In-Reply-To: <20140111181432.GB15937-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On 01/11/2014 07:14 PM, Russell King - ARM Linux wrote:
> On Thu, Jan 09, 2014 at 12:04:12PM +0100, Jean-Francois Moine wrote:
>> @@ -1250,6 +1311,39 @@ tda998x_encoder_init(struct i2c_client *client,
>> priv->vip_cntrl_2 = video;
>> }
>>
>> + /* install the optional HDMI connect IRQ */
>> + priv->int_irq = irq_of_parse_and_map(np, 0);
>> + if (priv->int_irq < 0)
>> + priv->int_irq = NO_IRQ;
>> + if (priv->int_irq != NO_IRQ) {
>
> NAK. Do not use NO_IRQ. Use <= 0 instead, or just test against zero for
> no IRQ. It would also be nice to offer this facility to non-DT platforms
> via client->irq. Not every arch in the Linux kernel uses DT.
At least for the DT part, I'd suggest to not ask for interrupt directly
but use a proper gpios property. The can of course be converted to
priv->int_irq in some tda998x_dt_probe.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jean-Francois Moine <moinejf@free.fr>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Rob Clark <robdclark@gmail.com>, Dave Airlie <airlied@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read
Date: Sat, 11 Jan 2014 19:35:21 +0100 [thread overview]
Message-ID: <52D18EE9.5030305@gmail.com> (raw)
In-Reply-To: <20140111181432.GB15937@n2100.arm.linux.org.uk>
On 01/11/2014 07:14 PM, Russell King - ARM Linux wrote:
> On Thu, Jan 09, 2014 at 12:04:12PM +0100, Jean-Francois Moine wrote:
>> @@ -1250,6 +1311,39 @@ tda998x_encoder_init(struct i2c_client *client,
>> priv->vip_cntrl_2 = video;
>> }
>>
>> + /* install the optional HDMI connect IRQ */
>> + priv->int_irq = irq_of_parse_and_map(np, 0);
>> + if (priv->int_irq < 0)
>> + priv->int_irq = NO_IRQ;
>> + if (priv->int_irq != NO_IRQ) {
>
> NAK. Do not use NO_IRQ. Use <= 0 instead, or just test against zero for
> no IRQ. It would also be nice to offer this facility to non-DT platforms
> via client->irq. Not every arch in the Linux kernel uses DT.
At least for the DT part, I'd suggest to not ask for interrupt directly
but use a proper gpios property. The can of course be converted to
priv->int_irq in some tda998x_dt_probe.
Sebastian
next prev parent reply other threads:[~2014-01-11 18:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 11:04 [PATCH v2 13/28] drm/i2c: tda998x: use irq for connection status and EDID read Jean-Francois Moine
2014-01-09 11:04 ` Jean-Francois Moine
2014-01-09 11:04 ` Jean-Francois Moine
2014-01-11 18:14 ` Russell King - ARM Linux
2014-01-11 18:14 ` Russell King - ARM Linux
2014-01-11 18:14 ` Russell King - ARM Linux
2014-01-11 18:35 ` Sebastian Hesselbarth [this message]
2014-01-11 18:35 ` Sebastian Hesselbarth
2014-01-11 18:35 ` Sebastian Hesselbarth
2014-01-12 18:51 ` Jean-Francois Moine
2014-01-12 18:51 ` Jean-Francois Moine
2014-01-12 18:51 ` Jean-Francois Moine
2014-01-12 19:26 ` Sebastian Hesselbarth
2014-01-12 19:26 ` Sebastian Hesselbarth
2014-01-12 19:26 ` Sebastian Hesselbarth
2014-01-17 17:27 ` Jean-Francois Moine
2014-01-17 17:27 ` Jean-Francois Moine
2014-01-17 17:27 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D18EE9.5030305@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.