From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wolfgang Grandegger" <wg@grandegger.com>
Cc: linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH can-utils 2/3] ioctl.h: drop unused header
Date: Sun, 12 Jan 2014 11:18:51 +0100 [thread overview]
Message-ID: <52D26C0B.7080109@hartkopp.net> (raw)
In-Reply-To: <1389481823-8379-3-git-send-email-u.kleine-koenig@pengutronix.de>
This is a relict from the first implementation of a CAN driver configuration
interface from 2006.
As the current can-utils do not reference them nor the ioctl interface has any
relevance removing this file is a good idea :-)
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Tnx Uwe!
On 12.01.2014 00:10, Uwe Kleine-König wrote:
> This header doesn't exist in the Linux tree and it's unused by can-utils,
> so drop it. As a side effect this fixes the last file not specifying any
> license and/or copyright information.
> ---
> GNUmakefile.am | 1 -
> include/socketcan/can/ioctl.h | 99 -------------------------------------------
> 2 files changed, 100 deletions(-)
> delete mode 100644 include/socketcan/can/ioctl.h
>
> diff --git a/GNUmakefile.am b/GNUmakefile.am
> index fc8f6e73e139..8c18e72794fa 100644
> --- a/GNUmakefile.am
> +++ b/GNUmakefile.am
> @@ -23,7 +23,6 @@ noinst_HEADERS = \
> include/socketcan/can/error.h \
> include/socketcan/can/gw.h \
> include/socketcan/can.h \
> - include/socketcan/can/ioctl.h \
> include/socketcan/can/isotp.h \
> include/socketcan/can/netlink.h \
> include/socketcan/can/raw.h
> diff --git a/include/socketcan/can/ioctl.h b/include/socketcan/can/ioctl.h
> deleted file mode 100644
> index ab34e8918667..000000000000
> --- a/include/socketcan/can/ioctl.h
> +++ /dev/null
> @@ -1,99 +0,0 @@
> -
> -/*
> - * socketcan/can/ioctl.h
> - *
> - * Definitions for CAN controller setup (work in progress)
> - *
> - * $Id$
> - *
> - * Send feedback to <linux-can@vger.kernel.org>
> - *
> - */
> -
> -#ifndef CAN_IOCTL_H
> -#define CAN_IOCTL_H
> -
> -#include <linux/sockios.h>
> -
> -/*
> - * CAN bitrate
> - */
> -#define CAN_BITRATE_UNCONFIGURED ((__u32) 0xFFFFFFFFU)
> -#define CAN_BITRATE_UNKNOWN 0
> -#define CAN_BITRATE_DEFAULT 500000
> -
> -/*
> - * CAN custom bit time
> - */
> -enum can_bittimes {
> - CAN_BITTIME_STD,
> - CAN_BITTIME_BTR
> -};
> -
> -/* TSEG1 of controllers usually is a sum of synch_seg (always 1),
> - * prop_seg and phase_seg1, TSEG2 = phase_seg2 */
> -
> -struct can_bittime_std {
> - __u32 brp; /* baud rate prescaler */
> - __u8 prop_seg; /* from 1 to 8 */
> - __u8 phase_seg1; /* from 1 to 8 */
> - __u8 phase_seg2; /* from 1 to 8 */
> - __u8 sjw:7; /* from 1 to 4 */
> - __u8 sam:1; /* 1 - enable triple sampling */
> -};
> -
> -struct can_bittime_btr {
> - __u8 btr0;
> - __u8 btr1;
> -};
> -
> -struct can_bittime {
> - enum can_bittimes type;
> - union {
> - struct can_bittime_std std;
> - struct can_bittime_btr btr;
> - };
> -};
> -
> -/*
> - * CAN mode
> - */
> -enum can_mode {
> - CAN_MODE_STOP = 0,
> - CAN_MODE_START,
> - CAN_MODE_SLEEP
> -};
> -
> -/*
> - * CAN controller mode
> - */
> -#define CAN_CTRLMODE_LOOPBACK 0x1
> -#define CAN_CTRLMODE_LISTENONLY 0x2
> -
> -/*
> - * CAN operational and error states
> - */
> -enum can_state {
> - CAN_STATE_ACTIVE = 0,
> - CAN_STATE_BUS_WARNING,
> - CAN_STATE_BUS_PASSIVE,
> - CAN_STATE_BUS_OFF,
> - CAN_STATE_STOPPED,
> - CAN_STATE_SLEEPING
> -};
> -
> -/*
> - * CAN device statistics
> - */
> -struct can_device_stats {
> - int error_warning;
> - int data_overrun;
> - int wakeup;
> - int bus_error;
> - int error_passive;
> - int arbitration_lost;
> - int restarts;
> - int bus_error_at_init;
> -};
> -
> -#endif /* CAN_IOCTL_H */
>
next prev parent reply other threads:[~2014-01-12 10:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 19:05 license issues of can-utils Uwe Kleine-König
2013-08-17 20:24 ` Marc Kleine-Budde
2013-08-18 10:26 ` Oliver Hartkopp
2014-01-11 23:10 ` [PATCH can-utils 0/3] License cleanup Uwe Kleine-König
2014-01-11 23:10 ` [PATCH can-utils 1/3] Update license information for some header files Uwe Kleine-König
2014-01-12 10:09 ` Oliver Hartkopp
2014-01-12 19:02 ` [PATCH] can: add explicit copyrights to can userspace header Uwe Kleine-König
2014-01-12 19:27 ` Oliver Hartkopp
2014-01-16 16:27 ` Marc Kleine-Budde
2014-01-12 19:53 ` [PATCH can-utils 1/3] Update license information for some header files Uwe Kleine-König
2014-01-11 23:10 ` [PATCH can-utils 2/3] ioctl.h: drop unused header Uwe Kleine-König
2014-01-12 10:18 ` Oliver Hartkopp [this message]
2014-01-11 23:10 ` [PATCH can-utils 3/3] slcand: remove program as it is undistributable Uwe Kleine-König
2014-01-11 23:38 ` Yegor Yefremov
2014-01-12 10:57 ` Oliver Hartkopp
2014-01-12 16:09 ` Yegor Yefremov
2014-01-12 18:22 ` Oliver Hartkopp
2014-01-12 19:54 ` Yegor Yefremov
2014-01-12 19:59 ` Oliver Hartkopp
2014-01-12 21:24 ` [PATCH can-utils v2 0/3] License cleanup Uwe Kleine-König
2014-01-12 21:24 ` [PATCH can-utils v2 1/3] headers: use include/linux only for Linux kernel headers Uwe Kleine-König
2014-01-13 6:23 ` Oliver Hartkopp
2014-01-13 7:20 ` Uwe Kleine-König
2014-01-13 18:25 ` Oliver Hartkopp
2014-01-13 20:45 ` Uwe Kleine-König
2014-01-13 21:18 ` Oliver Hartkopp
2014-01-13 21:26 ` Uwe Kleine-König
2014-01-13 21:31 ` Oliver Hartkopp
2014-01-13 21:37 ` Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 0/4] License cleanup Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 1/4] Remove two unused header files Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 2/4] Move includes copied from the Linux kernel into include/linux Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 3/4] ioctl.h: drop unused header Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 4/4] isotp.h: add explicit license information Uwe Kleine-König
2014-01-14 7:01 ` Oliver Hartkopp
2014-01-14 8:46 ` Uwe Kleine-König
2014-01-14 15:49 ` Oliver Hartkopp
2014-01-16 19:18 ` Uwe Kleine-König
2014-01-16 22:05 ` Marc Kleine-Budde
2014-01-12 21:24 ` [PATCH can-utils v2 2/3] ioctl.h: drop unused header Uwe Kleine-König
2014-01-12 21:24 ` [PATCH can-utils v2 3/3] isotp.h: add explicit license information Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D26C0B.7080109@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.