Re: [PATCH can-utils v4 4/4] isotp.h: add explicit license information

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]

On 01/16/2014 08:18 PM, Uwe Kleine-König wrote:
>> On Tue, Jan 14, 2014 at 08:01:33AM +0100, Oliver Hartkopp wrote:
>>> On 13.01.2014 22:57, Uwe Kleine-König wrote:
>>>> It seems this file was originally part of the Linux kernel as it was created
>>>> by commit 77de10356fe0 (include: import kernel header files into tree) but I
>>>> couldn't find it in the git history of the kernel.
>>>
>>> This comes from the original development process in the BerliOS SVN.
>>> The fact that these files are kernel header files does not necessarily mean
>>> they have been imported from the kernel source tree :-)
>> Strange concept. Either you need some additional Userspace API in the
>> kernel for your isotp programs or you don't. In the first case there
>> must be a header in the kernel providing that API (if not in mainline
>> that at least in some can tree). In the latter case where everything
>> works with the kernel as is, you shouldn't declare something to be a
>> kernel header that doesn't need to.

> Looking a bit into the isotp*.c files it seems the isotp header falls
> into the first category, i.e. you need kernel support to use these. Is
> that correct? Is there an up-to-date kernel tree somewhere that holds
> the necessary patches? If yes, I suggest to document that tree somewhere
> in can-utils to be the source for the kernel headers.

Isotp is an external Kernel module.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]