[PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[Oleksij Rempel]

Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
---
 drivers/platform/x86/acer-wmi.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index c9076bd..d5ca1648 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -572,6 +572,14 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5750"),
 		},
 	},
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer Aspire E1-572",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire E1-572"),
+		},
+	},
 	{}
 };
 
-- 
1.8.3.2

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[joeyli]

Hi Oleksij, 

於 四，2013-12-05 於 14:00 +0100，Oleksij Rempel 提到：
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> ---
>  drivers/platform/x86/acer-wmi.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index c9076bd..d5ca1648 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -572,6 +572,14 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5750"),
>  		},
>  	},
> +	{
> +		.callback = video_set_backlight_video_vendor,
> +		.ident = "Acer Aspire E1-572",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire E1-572"),
> +		},
> +	},
>  	{}
>  };
>  

I have applied this patch, build and load acer-wmi driver, didn't see
problem.

Acked-by: Lee, Chun-Yi <jlee@suse.com>


Thanks for your patch!
Joey Lee

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[joeyli]

Hi Oleksij, 

於 五，2013-12-27 於 11:51 +0800，joeyli 提到：
> Hi Oleksij, 
> 
> 於 四，2013-12-05 於 14:00 +0100，Oleksij Rempel 提到：
> > Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> > ---
> >  drivers/platform/x86/acer-wmi.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> > index c9076bd..d5ca1648 100644
> > --- a/drivers/platform/x86/acer-wmi.c
> > +++ b/drivers/platform/x86/acer-wmi.c
> > @@ -572,6 +572,14 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
> >  			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5750"),
> >  		},
> >  	},
> > +	{
> > +		.callback = video_set_backlight_video_vendor,
> > +		.ident = "Acer Aspire E1-572",
> > +		.matches = {
> > +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire E1-572"),
> > +		},
> > +	},
> >  	{}
> >  };
> >  
> 
> I have applied this patch, build and load acer-wmi driver, didn't see
> problem.
> 
> Acked-by: Lee, Chun-Yi <jlee@suse.com>
> 
> 
> Thanks for your patch!
> Joey Lee

I just aware Aspire E1-572 shipped with Windows 8. Before merge this
patch. Could you please try v3.13-rc5 kernel with
video.use_native_backlight=1 kernel parameter?

Aaron Lu's "[PATCH v5 0/4] Fix Win8 backlight issue" merged to mainline
in v3.13-rc1, his patches works to me on a Gateway Windows 8 notebook.

Please try it, if Aaron's patches works on E1-572, then we don't need
this patch.


Thanks a lot!
Joey Lee

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[Oleksij Rempel]

[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]

Am 27.12.2013 05:25, schrieb joeyli:
> Hi Oleksij, 
> 
> 於 五，2013-12-27 於 11:51 +0800，joeyli 提到：
>> Hi Oleksij, 
>>
>> 於 四，2013-12-05 於 14:00 +0100，Oleksij Rempel 提到：
>>> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
>>> ---
>>>  drivers/platform/x86/acer-wmi.c | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>>> index c9076bd..d5ca1648 100644
>>> --- a/drivers/platform/x86/acer-wmi.c
>>> +++ b/drivers/platform/x86/acer-wmi.c
>>> @@ -572,6 +572,14 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
>>>  			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5750"),
>>>  		},
>>>  	},
>>> +	{
>>> +		.callback = video_set_backlight_video_vendor,
>>> +		.ident = "Acer Aspire E1-572",
>>> +		.matches = {
>>> +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
>>> +			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire E1-572"),
>>> +		},
>>> +	},
>>>  	{}
>>>  };
>>>  
>>
>> I have applied this patch, build and load acer-wmi driver, didn't see
>> problem.
>>
>> Acked-by: Lee, Chun-Yi <jlee@suse.com>
>>
>>
>> Thanks for your patch!
>> Joey Lee
> 
> I just aware Aspire E1-572 shipped with Windows 8. Before merge this
> patch. Could you please try v3.13-rc5 kernel with
> video.use_native_backlight=1 kernel parameter?
> 
> Aaron Lu's "[PATCH v5 0/4] Fix Win8 backlight issue" merged to mainline
> in v3.13-rc1, his patches works to me on a Gateway Windows 8 notebook.
> 
> Please try it, if Aaron's patches works on E1-572, then we don't need
> this patch.

Hi,

suddenly i do not have access to this Laptops any more. It was a
purchase for a friend. I tested it, provided some patch and gave it away :(

-- 
Regards,
Oleksij


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[joeyli]

於 三，2014-01-01 於 15:37 +0100，Oleksij Rempel 提到：
> Am 27.12.2013 05:25, schrieb joeyli:
[...]
> >>>  		},
> >>>  	},
> >>> +	{
> >>> +		.callback = video_set_backlight_video_vendor,
> >>> +		.ident = "Acer Aspire E1-572",
> >>> +		.matches = {
> >>> +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
> >>> +			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire E1-572"),
> >>> +		},
> >>> +	},
> >>>  	{}
> >>>  };
> >>>  
> >>
> >> I have applied this patch, build and load acer-wmi driver, didn't see
> >> problem.
> >>
> >> Acked-by: Lee, Chun-Yi <jlee@suse.com>
> >>
> >>
> >> Thanks for your patch!
> >> Joey Lee
> > 
> > I just aware Aspire E1-572 shipped with Windows 8. Before merge this
> > patch. Could you please try v3.13-rc5 kernel with
> > video.use_native_backlight=1 kernel parameter?
> > 
> > Aaron Lu's "[PATCH v5 0/4] Fix Win8 backlight issue" merged to mainline
> > in v3.13-rc1, his patches works to me on a Gateway Windows 8 notebook.
> > 
> > Please try it, if Aaron's patches works on E1-572, then we don't need
> > this patch.
> 
> Hi,
> 
> suddenly i do not have access to this Laptops any more. It was a
> purchase for a friend. I tested it, provided some patch and gave it away :(
> 

I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
version released then look at maybe someone report issue again.

Very appreciate for your patch.

Joey Lee

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[Oleksij Rempel]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

Am 02.01.2014 13:39, schrieb joeyli:
> 於 三，2014-01-01 於 15:37 +0100，Oleksij Rempel 提到：
>> Am 27.12.2013 05:25, schrieb joeyli:
> [...]
>>>>>  		},
>>>>>  	},
>>>>> +	{
>>>>> +		.callback = video_set_backlight_video_vendor,
>>>>> +		.ident = "Acer Aspire E1-572",
>>>>> +		.matches = {
>>>>> +			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
>>>>> +			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire E1-572"),
>>>>> +		},
>>>>> +	},
>>>>>  	{}
>>>>>  };
>>>>>  
>>>>
>>>> I have applied this patch, build and load acer-wmi driver, didn't see
>>>> problem.
>>>>
>>>> Acked-by: Lee, Chun-Yi <jlee@suse.com>
>>>>
>>>>
>>>> Thanks for your patch!
>>>> Joey Lee
>>>
>>> I just aware Aspire E1-572 shipped with Windows 8. Before merge this
>>> patch. Could you please try v3.13-rc5 kernel with
>>> video.use_native_backlight=1 kernel parameter?
>>>
>>> Aaron Lu's "[PATCH v5 0/4] Fix Win8 backlight issue" merged to mainline
>>> in v3.13-rc1, his patches works to me on a Gateway Windows 8 notebook.
>>>
>>> Please try it, if Aaron's patches works on E1-572, then we don't need
>>> this patch.
>>
>> Hi,
>>
>> suddenly i do not have access to this Laptops any more. It was a
>> purchase for a friend. I tested it, provided some patch and gave it away :(
>>
> 
> I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
> version released then look at maybe someone report issue again.
> 
> Very appreciate for your patch.
> 
> Joey Lee
> 

Hi Joey,

i have access to this hardware for next two weeks. Theoretically this
kernel should have patches you was talking about:
http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/

it works with video.use_native_backlight=1.

If you need more testing, you have two weeks ;)

-- 
Regards,
Oleksij


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[joeyli]

於 一，2014-01-06 於 17:20 +0100，Oleksij Rempel 提到：
> > I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
> > version released then look at maybe someone report issue again.
> > 
> > Very appreciate for your patch.
> > 
> > Joey Lee
> > 
> 
> Hi Joey,
> 
> i have access to this hardware for next two weeks. Theoretically this
> kernel should have patches you was talking about:
> http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/
> 
> it works with video.use_native_backlight=1.
> 
> If you need more testing, you have two weeks ;)
> 
> -- 
> Regards,
> Oleksij
> 

Thanks for your testing, then I think just use
video.use_native_backlight to fix issue on Aspire E1-572. Don't need add
quirk to acer-wmi driver.


Thanks a lot!
Joey Lee

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[Oleksij Rempel]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Am 09.01.2014 08:06, schrieb joeyli:
> 於 一，2014-01-06 於 17:20 +0100，Oleksij Rempel 提到：
>>> I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
>>> version released then look at maybe someone report issue again.
>>>
>>> Very appreciate for your patch.
>>>
>>> Joey Lee
>>>
>>
>> Hi Joey,
>>
>> i have access to this hardware for next two weeks. Theoretically this
>> kernel should have patches you was talking about:
>> http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/
>>
>> it works with video.use_native_backlight=1.
>>
>> If you need more testing, you have two weeks ;)
>>
>> -- 
>> Regards,
>> Oleksij
>>
> 
> Thanks for your testing, then I think just use
> video.use_native_backlight to fix issue on Aspire E1-572. Don't need add
> quirk to acer-wmi driver.

You mean editing grub and adding kernel option?

-- 
Regards,
Oleksij


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[joeyli]

於 四，2014-01-09 於 09:11 +0100，Oleksij Rempel 提到：
> Am 09.01.2014 08:06, schrieb joeyli:
> > 於 一，2014-01-06 於 17:20 +0100，Oleksij Rempel 提到：
> >>> I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
> >>> version released then look at maybe someone report issue again.
> >>>
> >>> Very appreciate for your patch.
> >>>
> >>> Joey Lee
> >>>
> >>
> >> Hi Joey,
> >>
> >> i have access to this hardware for next two weeks. Theoretically this
> >> kernel should have patches you was talking about:
> >> http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/
> >>
> >> it works with video.use_native_backlight=1.
> >>
> >> If you need more testing, you have two weeks ;)
> >>
> >> -- 
> >> Regards,
> >> Oleksij
> >>
> > 
> > Thanks for your testing, then I think just use
> > video.use_native_backlight to fix issue on Aspire E1-572. Don't need add
> > quirk to acer-wmi driver.
> 
> You mean editing grub and adding kernel option?

Good point!

Looks we need add Aspire E1-572 to the video_dmi_table in
drivers/acpi/video.c, like:
http://lists.freedesktop.org/archives/dri-devel/2013-November/049427.html

But this patch doesn't in mainline. 

Do you want send a patch to Aaron Lu for add Aspire E1-572 to list? or
maybe we can ping Aaron to direct add it.


Thanks a lot!
Joey Lee

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[Aaron Lu]

On 01/09/2014 05:05 PM, joeyli wrote:
> 於 四，2014-01-09 於 09:11 +0100，Oleksij Rempel 提到：
>> Am 09.01.2014 08:06, schrieb joeyli:
>>> 於 一，2014-01-06 於 17:20 +0100，Oleksij Rempel 提到：
>>>>> I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
>>>>> version released then look at maybe someone report issue again.
>>>>>
>>>>> Very appreciate for your patch.
>>>>>
>>>>> Joey Lee
>>>>>
>>>>
>>>> Hi Joey,
>>>>
>>>> i have access to this hardware for next two weeks. Theoretically this
>>>> kernel should have patches you was talking about:
>>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/
>>>>
>>>> it works with video.use_native_backlight=1.
>>>>
>>>> If you need more testing, you have two weeks ;)
>>>>
>>>> -- 
>>>> Regards,
>>>> Oleksij
>>>>
>>>
>>> Thanks for your testing, then I think just use
>>> video.use_native_backlight to fix issue on Aspire E1-572. Don't need add
>>> quirk to acer-wmi driver.
>>
>> You mean editing grub and adding kernel option?
> 
> Good point!
> 
> Looks we need add Aspire E1-572 to the video_dmi_table in
> drivers/acpi/video.c, like:
> http://lists.freedesktop.org/archives/dri-devel/2013-November/049427.html
> 
> But this patch doesn't in mainline. 
> 
> Do you want send a patch to Aaron Lu for add Aspire E1-572 to list? or
> maybe we can ping Aaron to direct add it.

Since it is shipped with Win8, I think the following patch should take
care of it:
[PATCH] ACPI / video: Use native backlight control interface by default
http://www.spinics.net/lists/linux-acpi/msg47755.html

Last time Daniel seems to agree to merge it for test purpose, but I
didn't see it get merged somewhere yet.

Thanks,
Aaron

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[joeyli]

於 一，2014-01-13 於 10:49 +0800，Aaron Lu 提到：
> On 01/09/2014 05:05 PM, joeyli wrote:
> > 於 四，2014-01-09 於 09:11 +0100，Oleksij Rempel 提到：
> >> Am 09.01.2014 08:06, schrieb joeyli:
> >>> 於 一，2014-01-06 於 17:20 +0100，Oleksij Rempel 提到：
> >>>>> I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
> >>>>> version released then look at maybe someone report issue again.
> >>>>>
> >>>>> Very appreciate for your patch.
> >>>>>
> >>>>> Joey Lee
> >>>>>
> >>>>
> >>>> Hi Joey,
> >>>>
> >>>> i have access to this hardware for next two weeks. Theoretically this
> >>>> kernel should have patches you was talking about:
> >>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/
> >>>>
> >>>> it works with video.use_native_backlight=1.
> >>>>
> >>>> If you need more testing, you have two weeks ;)
> >>>>
> >>>> -- 
> >>>> Regards,
> >>>> Oleksij
> >>>>
> >>>
> >>> Thanks for your testing, then I think just use
> >>> video.use_native_backlight to fix issue on Aspire E1-572. Don't need add
> >>> quirk to acer-wmi driver.
> >>
> >> You mean editing grub and adding kernel option?
> > 
> > Good point!
> > 
> > Looks we need add Aspire E1-572 to the video_dmi_table in
> > drivers/acpi/video.c, like:
> > http://lists.freedesktop.org/archives/dri-devel/2013-November/049427.html
> > 
> > But this patch doesn't in mainline. 
> > 
> > Do you want send a patch to Aaron Lu for add Aspire E1-572 to list? or
> > maybe we can ping Aaron to direct add it.
> 
> Since it is shipped with Win8, I think the following patch should take
> care of it:
> [PATCH] ACPI / video: Use native backlight control interface by default
> http://www.spinics.net/lists/linux-acpi/msg47755.html
> 
> Last time Daniel seems to agree to merge it for test purpose, but I
> didn't see it get merged somewhere yet.
> 
> Thanks,
> Aaron
> 

Will we removed all video_set_use_native_backlight devices in
video_dmi_table quirk table after the above patch merged?

Just wonder what is our strategy of those issue machines? Add to quirk
table or will enable native backlight control by default?


Thanks a lot!
Joey Lee

Re: [PATCH] acer-wmi: add video_vendor quirk for Acer Aspire E1-572

[Aaron Lu]

On 01/13/2014 03:05 PM, joeyli wrote:
> 於 一，2014-01-13 於 10:49 +0800，Aaron Lu 提到：
>> On 01/09/2014 05:05 PM, joeyli wrote:
>>> 於 四，2014-01-09 於 09:11 +0100，Oleksij Rempel 提到：
>>>> Am 09.01.2014 08:06, schrieb joeyli:
>>>>> 於 一，2014-01-06 於 17:20 +0100，Oleksij Rempel 提到：
>>>>>>> I think Aaron's patches can fix it on E1-572. Let's wait until v3.13
>>>>>>> version released then look at maybe someone report issue again.
>>>>>>>
>>>>>>> Very appreciate for your patch.
>>>>>>>
>>>>>>> Joey Lee
>>>>>>>
>>>>>>
>>>>>> Hi Joey,
>>>>>>
>>>>>> i have access to this hardware for next two weeks. Theoretically this
>>>>>> kernel should have patches you was talking about:
>>>>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/daily/2014-01-06-trusty/
>>>>>>
>>>>>> it works with video.use_native_backlight=1.
>>>>>>
>>>>>> If you need more testing, you have two weeks ;)
>>>>>>
>>>>>> -- 
>>>>>> Regards,
>>>>>> Oleksij
>>>>>>
>>>>>
>>>>> Thanks for your testing, then I think just use
>>>>> video.use_native_backlight to fix issue on Aspire E1-572. Don't need add
>>>>> quirk to acer-wmi driver.
>>>>
>>>> You mean editing grub and adding kernel option?
>>>
>>> Good point!
>>>
>>> Looks we need add Aspire E1-572 to the video_dmi_table in
>>> drivers/acpi/video.c, like:
>>> http://lists.freedesktop.org/archives/dri-devel/2013-November/049427.html
>>>
>>> But this patch doesn't in mainline. 
>>>
>>> Do you want send a patch to Aaron Lu for add Aspire E1-572 to list? or
>>> maybe we can ping Aaron to direct add it.
>>
>> Since it is shipped with Win8, I think the following patch should take
>> care of it:
>> [PATCH] ACPI / video: Use native backlight control interface by default
>> http://www.spinics.net/lists/linux-acpi/msg47755.html
>>
>> Last time Daniel seems to agree to merge it for test purpose, but I
>> didn't see it get merged somewhere yet.
>>
>> Thanks,
>> Aaron
>>
> 
> Will we removed all video_set_use_native_backlight devices in
> video_dmi_table quirk table after the above patch merged?
> 
> Just wonder what is our strategy of those issue machines? Add to quirk
> table or will enable native backlight control by default?

For Win8 laptops, perhaps enable native backlight control by default.

Thanks,
Aaron
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html