All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc:Rename CONFIG_PBLRCW_CONFIG & CONFIG_SYS_FSL_PBL_PBI
Date: Mon, 13 Jan 2014 11:13:17 +0530	[thread overview]
Message-ID: <52D37CF5.2090100@freescale.com> (raw)
In-Reply-To: <20140113053254.D9DF83821EB@gemini.denx.de>

Thanks Wolfgang for reviewing this patch.
Please find my reply in-lined


On 1/13/2014 11:02 AM, Wolfgang Denk wrote:
> Dear Prabhakar Kushwaha,
>
> In message <1389587917-10324-1-git-send-email-prabhakar@freescale.com> you wrote:
>> Rename CONFIG_PBLRCW_CONFIG and CONFIG_PBLRCW_CONFIG.
> What is the reason for the reenaming?  Especially, why changing from
> CONFIG_ to CONFIG_SYS_ ?

CONFIG_PBLRCW_CONFIG has 2 CONFIG. it is slightly confusing.

Reason for moving CONFIG_ to CONFIG_SYS:  These defines enables of 
adding RCW(power on reset configuration) and
PBI(pre boot loader commands) in u-boot image. These information will be 
used by SoC hardware for NAND, SD, SPI boot.
As these configuration will be used by SoC hardware. I thought of adding 
CONFIG_SYS.

Please let me know, if I need to rename it again.

>> Also add their details in README.
> ...
>
>> +		CONFIG_SYS_FSL_PBL_PBI
>> +		CONFIG_SYS_FSL_PBL_RCW
>> +		Provides a tool to build boot Image for PBL(Pre boot loader)
>> +		Here PBL can be used to load some instructions and/or data for
>> +		pre-initialization.
>> +		Define both configs to enable above feature.
> Hm...This does not really explain what CONFIG_SYS_FSL_PBL_PBI or
> CONFIG_SYS_FSL_PBL_RCW actually means.
>
>
You are right. Let me correct it.

Thanks,
Prabhakar

  reply	other threads:[~2014-01-13  5:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13  4:38 [U-Boot] [PATCH] powerpc:Rename CONFIG_PBLRCW_CONFIG & CONFIG_SYS_FSL_PBL_PBI Prabhakar Kushwaha
2014-01-13  5:32 ` Wolfgang Denk
2014-01-13  5:43   ` Prabhakar Kushwaha [this message]
2014-01-13 13:48     ` Wolfgang Denk
2014-01-13 18:32       ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D37CF5.2090100@freescale.com \
    --to=prabhakar@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.