* [3.13-rc regression] Unbreak Loongson2 and r4k-generic flush icache range
@ 2014-01-13 11:26 Alexandre Oliva
2014-01-13 13:31 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Alexandre Oliva @ 2014-01-13 11:26 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, linux-kernel
Commit 14bd8c08, that replaced Loongson2-specific ifdefs with cpu tests,
inverted the CPU test in local_r4k_flush_icache_range. Loongson2 won't
boot up using the generic icache flush code. Presumably other CPUs
might face other problems when presented with Loongson2-specific icache
flush code too. This patch enabled my Yeeloong to boot up successfully
a 3.13-rc kernel for the first time, after a long git bisect session.
Signed-off-by: Alexandre Oliva <lxoliva@fsfla.org>
---
arch/mips/mm/c-r4k.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
index 62ffd20..1c2029d 100644
--- a/arch/mips/mm/c-r4k.c
+++ b/arch/mips/mm/c-r4k.c
@@ -580,11 +580,11 @@ static inline void local_r4k_flush_icache_range(unsigned long start, unsigned lo
else {
switch (boot_cpu_type()) {
case CPU_LOONGSON2:
- protected_blast_icache_range(start, end);
+ protected_loongson23_blast_icache_range(start, end);
break;
default:
- protected_loongson23_blast_icache_range(start, end);
+ protected_blast_icache_range(start, end);
break;
}
}
--
1.8.3.1
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [3.13-rc regression] Unbreak Loongson2 and r4k-generic flush icache range
2014-01-13 11:26 [3.13-rc regression] Unbreak Loongson2 and r4k-generic flush icache range Alexandre Oliva
@ 2014-01-13 13:31 ` Sergei Shtylyov
2014-01-13 13:41 ` John Crispin
2014-01-14 10:01 ` Alexandre Oliva
0 siblings, 2 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2014-01-13 13:31 UTC (permalink / raw)
To: Alexandre Oliva, Ralf Baechle; +Cc: linux-mips, linux-kernel
Hello.
On 13-01-2014 15:26, Alexandre Oliva wrote:
> Commit 14bd8c08, that replaced Loongson2-specific ifdefs with cpu tests,
Please also specify that commit's summary line in parens.
> inverted the CPU test in local_r4k_flush_icache_range. Loongson2 won't
> boot up using the generic icache flush code. Presumably other CPUs
> might face other problems when presented with Loongson2-specific icache
> flush code too. This patch enabled my Yeeloong to boot up successfully
> a 3.13-rc kernel for the first time, after a long git bisect session.
> Signed-off-by: Alexandre Oliva <lxoliva@fsfla.org>
Fix for this issue has been posted long ago:
http://marc.info/?l=linux-mips&m=138575576803890
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [3.13-rc regression] Unbreak Loongson2 and r4k-generic flush icache range
2014-01-13 13:31 ` Sergei Shtylyov
@ 2014-01-13 13:41 ` John Crispin
2014-01-13 18:26 ` Aaro Koskinen
2014-01-14 10:01 ` Alexandre Oliva
1 sibling, 1 reply; 6+ messages in thread
From: John Crispin @ 2014-01-13 13:41 UTC (permalink / raw)
To: linux-mips
On 13/01/14 14:31, Sergei Shtylyov wrote:
> Hello.
>
> On 13-01-2014 15:26, Alexandre Oliva wrote:
>
>> Commit 14bd8c08, that replaced Loongson2-specific ifdefs with cpu tests,
>
> Please also specify that commit's summary line in parens.
>
>> inverted the CPU test in local_r4k_flush_icache_range. Loongson2 won't
>> boot up using the generic icache flush code. Presumably other CPUs
>> might face other problems when presented with Loongson2-specific icache
>> flush code too. This patch enabled my Yeeloong to boot up successfully
>> a 3.13-rc kernel for the first time, after a long git bisect session.
>
>> Signed-off-by: Alexandre Oliva <lxoliva@fsfla.org>
>
> Fix for this issue has been posted long ago:
>
> http://marc.info/?l=linux-mips&m=138575576803890
>
> WBR, Sergei
>
>
>
Hi,
i was under the impression that it is in rc8 but i am failing to see it
there.
John
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [3.13-rc regression] Unbreak Loongson2 and r4k-generic flush icache range
2014-01-13 13:41 ` John Crispin
@ 2014-01-13 18:26 ` Aaro Koskinen
0 siblings, 0 replies; 6+ messages in thread
From: Aaro Koskinen @ 2014-01-13 18:26 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mips
Hi,
On Mon, Jan 13, 2014 at 02:41:37PM +0100, John Crispin wrote:
> On 13/01/14 14:31, Sergei Shtylyov wrote:
> >On 13-01-2014 15:26, Alexandre Oliva wrote:
> >>Commit 14bd8c08, that replaced Loongson2-specific ifdefs with cpu tests,
> >
> >Fix for this issue has been posted long ago:
> >
> >http://marc.info/?l=linux-mips&m=138575576803890
>
> i was under the impression that it is in rc8 but i am failing to see
> it there.
The patches are currently in -mm tree, and hopefully will be in the
final 3.13.
A.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [3.13-rc regression] Unbreak Loongson2 and r4k-generic flush icache range
2014-01-13 13:31 ` Sergei Shtylyov
2014-01-13 13:41 ` John Crispin
@ 2014-01-14 10:01 ` Alexandre Oliva
2014-01-14 10:37 ` John Crispin
1 sibling, 1 reply; 6+ messages in thread
From: Alexandre Oliva @ 2014-01-14 10:01 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Ralf Baechle, linux-mips, linux-kernel
On Jan 13, 2014, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>> Commit 14bd8c08, that replaced Loongson2-specific ifdefs with cpu tests,
>> inverted the CPU test in local_r4k_flush_icache_range. Loongson2 won't
>> boot up using the generic icache flush code. Presumably other CPUs
>> might face other problems when presented with Loongson2-specific icache
>> flush code too. This patch enabled my Yeeloong to boot up successfully
>> a 3.13-rc kernel for the first time, after a long git bisect session.
>> Signed-off-by: Alexandre Oliva <lxoliva@fsfla.org>
> Fix for this issue has been posted long ago:
> http://marc.info/?l=linux-mips&m=138575576803890
Thanks. As long ago as that was, I still don't see it in Torvalds's
master branch. Was a pull request including this patch ever send his
way? Such a trivial fix for such a show-stopper shouldn't find any
difficulties making 3.13, I think.
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [3.13-rc regression] Unbreak Loongson2 and r4k-generic flush icache range
2014-01-14 10:01 ` Alexandre Oliva
@ 2014-01-14 10:37 ` John Crispin
0 siblings, 0 replies; 6+ messages in thread
From: John Crispin @ 2014-01-14 10:37 UTC (permalink / raw)
To: Alexandre Oliva, Sergei Shtylyov; +Cc: Ralf Baechle, linux-mips
i think all questions were already answered
http://www.linux-mips.org/archives/linux-mips/2014-01/msg00127.html
On 14/01/2014 11:01, Alexandre Oliva wrote:
> On Jan 13, 2014, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
>
>> Hello.
>>> Commit 14bd8c08, that replaced Loongson2-specific ifdefs with cpu tests,
>>> inverted the CPU test in local_r4k_flush_icache_range. Loongson2 won't
>>> boot up using the generic icache flush code. Presumably other CPUs
>>> might face other problems when presented with Loongson2-specific icache
>>> flush code too. This patch enabled my Yeeloong to boot up successfully
>>> a 3.13-rc kernel for the first time, after a long git bisect session.
>>> Signed-off-by: Alexandre Oliva <lxoliva@fsfla.org>
>> Fix for this issue has been posted long ago:
>> http://marc.info/?l=linux-mips&m=138575576803890
> Thanks. As long ago as that was, I still don't see it in Torvalds's
> master branch. Was a pull request including this patch ever send his
> way? Such a trivial fix for such a show-stopper shouldn't find any
> difficulties making 3.13, I think.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-14 10:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-13 11:26 [3.13-rc regression] Unbreak Loongson2 and r4k-generic flush icache range Alexandre Oliva
2014-01-13 13:31 ` Sergei Shtylyov
2014-01-13 13:41 ` John Crispin
2014-01-13 18:26 ` Aaro Koskinen
2014-01-14 10:01 ` Alexandre Oliva
2014-01-14 10:37 ` John Crispin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.