Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable

[Arjan van de Ven <arjan@linux.intel.com>]

On 1/13/2014 4:23 AM, Dave Young wrote:
>>
>>> How about do not limit to only if (pgd) case, instead do something
>>> like below: set dump_to_dmesg as a module parameter
>>
>> X86_PTDUMP is not a module.
>
> Hmm, I just see the module macros in the code, since it's a bool Kconfig
> I think the dump_pagetables.c need a cleanup,
> remove the #include <linux/module.h> and below lines:
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Arjan van de Ven <arjan@linux.intel.com>");
> MODULE_DESCRIPTION("Kernel debugging helper that dumps pagetables");

personally I consider it good form to always have this kind of information in .c files,
regardless of the KConfig side of thing...