From: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Arjan van de Ven <arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
Linux EFI <linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>,
Matt Fleming
<matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>,
Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>,
Toshi Kani <toshi.kani-VXdhtT5mjnY@public.gmane.org>
Subject: Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable
Date: Wed, 15 Jan 2014 20:04:37 -0800 [thread overview]
Message-ID: <52D75A55.2080503@zytor.com> (raw)
In-Reply-To: <20140116030343.GF3807-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On 01/15/2014 07:03 PM, Dave Young wrote:
>>
>> making something harder to grep and less standardized is hardly cleaner
>> and these things compile to nothing for non-modules.
>
> It's not nothing, just very small increasement:
> text data bss dec hex filename
> 7636121 1391824 9355264 18383209 1188169 vmlinux
>
> text data bss dec hex filename
> 7636113 1391824 9355264 18383201 1188161 vmlinux
>
> I do not want to insist on this minor problem, if you want please keep it.
>
Now *that* we can fix by making these macros expand to nothing if you
are compiling for a nonmodule, right? That will benefit code that
legitimately can compile as a module but is configured "y", too.
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Young <dyoung@redhat.com>, Arjan van de Ven <arjan@linux.intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
Linux EFI <linux-efi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>,
Matt Fleming <matt@console-pimps.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Toshi Kani <toshi.kani@hp.com>
Subject: Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable
Date: Wed, 15 Jan 2014 20:04:37 -0800 [thread overview]
Message-ID: <52D75A55.2080503@zytor.com> (raw)
In-Reply-To: <20140116030343.GF3807@dhcp-16-126.nay.redhat.com>
On 01/15/2014 07:03 PM, Dave Young wrote:
>>
>> making something harder to grep and less standardized is hardly cleaner
>> and these things compile to nothing for non-modules.
>
> It's not nothing, just very small increasement:
> text data bss dec hex filename
> 7636121 1391824 9355264 18383209 1188169 vmlinux
>
> text data bss dec hex filename
> 7636113 1391824 9355264 18383201 1188161 vmlinux
>
> I do not want to insist on this minor problem, if you want please keep it.
>
Now *that* we can fix by making these macros expand to nothing if you
are compiling for a nonmodule, right? That will benefit code that
legitimately can compile as a module but is configured "y", too.
-hpa
next prev parent reply other threads:[~2014-01-16 4:04 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 20:49 [PATCH 0/4] EFI memmap fix v2 Borislav Petkov
2014-01-11 20:49 ` Borislav Petkov
2014-01-11 20:49 ` [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable Borislav Petkov
[not found] ` <1389473370-1940-2-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2014-01-11 20:59 ` Joe Perches
2014-01-11 20:59 ` Joe Perches
2014-01-13 5:32 ` Dave Young
2014-01-13 5:32 ` Dave Young
[not found] ` <20140113053240.GA11237-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-01-13 10:18 ` Borislav Petkov
2014-01-13 10:18 ` Borislav Petkov
[not found] ` <20140113101822.GA5388-fF5Pk5pvG8Y@public.gmane.org>
2014-01-13 12:23 ` Dave Young
2014-01-13 12:23 ` Dave Young
2014-01-13 14:48 ` Arjan van de Ven
[not found] ` <52D3FCAA.7070004-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-01-13 14:57 ` Borislav Petkov
2014-01-13 14:57 ` Borislav Petkov
2014-01-14 1:40 ` Dave Young
2014-01-14 1:40 ` Dave Young
[not found] ` <20140114014003.GB4327-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-01-14 18:18 ` H. Peter Anvin
2014-01-14 18:18 ` H. Peter Anvin
[not found] ` <52D57F75.7060308-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2014-01-15 1:16 ` Dave Young
2014-01-15 1:16 ` Dave Young
[not found] ` <20140115011609.GD23767-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-01-15 14:11 ` H. Peter Anvin
2014-01-15 14:11 ` H. Peter Anvin
[not found] ` <52D6970D.3050701-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2014-01-16 1:44 ` Dave Young
2014-01-16 1:44 ` Dave Young
[not found] ` <20140116014457.GA3807-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-01-16 2:41 ` Arjan van de Ven
2014-01-16 2:41 ` Arjan van de Ven
[not found] ` <52D746D9.7030206-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-01-16 3:03 ` Dave Young
2014-01-16 3:03 ` Dave Young
[not found] ` <20140116030343.GF3807-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-01-16 4:04 ` H. Peter Anvin [this message]
2014-01-16 4:04 ` H. Peter Anvin
[not found] ` <52D75A55.2080503-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2014-01-16 6:46 ` Dave Young
2014-01-16 6:46 ` Dave Young
2014-01-16 6:54 ` Dave Young
[not found] ` <20140116064627.GC6356-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-01-16 14:52 ` Arjan van de Ven
2014-01-16 14:52 ` Arjan van de Ven
2014-01-13 15:49 ` Matt Fleming
[not found] ` <1389473370-1940-1-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2014-01-11 20:49 ` [PATCH 2/4] efi: Dump the EFI page table Borislav Petkov
2014-01-11 20:49 ` Borislav Petkov
[not found] ` <1389473370-1940-3-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2014-01-13 16:00 ` Matt Fleming
2014-01-13 16:00 ` Matt Fleming
[not found] ` <20140113160018.GJ3256-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-01-14 1:36 ` Dave Young
2014-01-14 1:36 ` Dave Young
2014-01-11 20:49 ` [PATCH 3/4] x86, pageattr: Export page unmapping interface Borislav Petkov
2014-01-11 20:49 ` Borislav Petkov
2014-01-11 20:49 ` [PATCH 4/4] efi: Make efi virtual runtime map passing more robust Borislav Petkov
2014-01-11 20:49 ` Borislav Petkov
[not found] ` <1389473370-1940-5-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2014-01-13 5:40 ` Dave Young
2014-01-13 5:40 ` Dave Young
[not found] ` <20140113054038.GB11237-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-01-13 10:27 ` Borislav Petkov
2014-01-13 10:27 ` Borislav Petkov
[not found] ` <20140113102734.GB5388-fF5Pk5pvG8Y@public.gmane.org>
2014-01-13 13:17 ` Dave Young
2014-01-13 13:17 ` Dave Young
2014-01-13 16:22 ` [PATCH 0/4] EFI memmap fix v2 Toshi Kani
2014-01-13 16:54 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D75A55.2080503@zytor.com \
--to=hpa-ymnouzjc4hwavxtiumwx3w@public.gmane.org \
--cc=arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=bp-l3A5Bk7waGM@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
--cc=toshi.kani-VXdhtT5mjnY@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.