All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: arch_timer: Set dynamic irq affinity on mmio clockevent
Date: Tue, 14 Jan 2014 09:40:10 +0100	[thread overview]
Message-ID: <52D4F7EA.6060200@linaro.org> (raw)
In-Reply-To: <1389048977-13502-1-git-send-email-sboyd@codeaurora.org>

On 01/06/2014 11:56 PM, Stephen Boyd wrote:
> Set the CLOCK_EVT_FEAT_DYNIRQ flag on the memory mapped
> clockevent so that we save power by waking up the CPU with the
> next event when this timer is used in broadcast mode.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>   drivers/clocksource/arm_arch_timer.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 95fb944e15ee..57e823c44d2a 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -277,6 +277,7 @@ static void __arch_timer_setup(unsigned type,
>   			clk->set_next_event = arch_timer_set_next_event_phys;
>   		}
>   	} else {
> +		clk->features |= CLOCK_EVT_FEAT_DYNIRQ;
>   		clk->name = "arch_mem_timer";
>   		clk->rating = 400;
>   		clk->cpumask = cpu_all_mask;
>

Applied in my tree for 3.15.

I am curious how much you saved in your current scenario. Did you had 
time to do some rough measurements ?

Thanks
   -- Daniel



-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] clocksource: arch_timer: Set dynamic irq affinity on mmio clockevent
Date: Tue, 14 Jan 2014 09:40:10 +0100	[thread overview]
Message-ID: <52D4F7EA.6060200@linaro.org> (raw)
In-Reply-To: <1389048977-13502-1-git-send-email-sboyd@codeaurora.org>

On 01/06/2014 11:56 PM, Stephen Boyd wrote:
> Set the CLOCK_EVT_FEAT_DYNIRQ flag on the memory mapped
> clockevent so that we save power by waking up the CPU with the
> next event when this timer is used in broadcast mode.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>   drivers/clocksource/arm_arch_timer.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 95fb944e15ee..57e823c44d2a 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -277,6 +277,7 @@ static void __arch_timer_setup(unsigned type,
>   			clk->set_next_event = arch_timer_set_next_event_phys;
>   		}
>   	} else {
> +		clk->features |= CLOCK_EVT_FEAT_DYNIRQ;
>   		clk->name = "arch_mem_timer";
>   		clk->rating = 400;
>   		clk->cpumask = cpu_all_mask;
>

Applied in my tree for 3.15.

I am curious how much you saved in your current scenario. Did you had 
time to do some rough measurements ?

Thanks
   -- Daniel



-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  reply	other threads:[~2014-01-14  8:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 22:56 [PATCH] clocksource: arch_timer: Set dynamic irq affinity on mmio clockevent Stephen Boyd
2014-01-06 22:56 ` Stephen Boyd
2014-01-14  8:40 ` Daniel Lezcano [this message]
2014-01-14  8:40   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D4F7EA.6060200@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.