From: Ben Dooks <ben.dooks@codethink.co.uk>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-kernel@lists.codethink.co.uk, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] power: clock_ops.c: check return of clk_enable() in pm_clk_resume()
Date: Tue, 14 Jan 2014 12:02:41 +0000 [thread overview]
Message-ID: <52D52761.1000303@codethink.co.uk> (raw)
In-Reply-To: <1438385.ppqm7XWTt3@vostro.rjw.lan>
On 13/01/14 19:55, Rafael J. Wysocki wrote:
> On Saturday, January 11, 2014 01:05:39 PM Ben Dooks wrote:
>> @@ -262,8 +263,9 @@ int pm_clk_resume(struct device *dev)
>>
>> list_for_each_entry(ce, &psd->clock_list, node) {
>> if (ce->status < PCE_STATUS_ERROR) {
>> - clk_enable(ce->clk);
>> - ce->status = PCE_STATUS_ENABLED;
>> + ret = clk_enable(ce->clk);
>> + if (ret == 0)
>
> Can you please use if (!ret) here?
>
> And analogously in patch [3/3]?
I will fix and re-send today, thanks.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-kernel@lists.codethink.co.uk, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] power: clock_ops.c: check return of clk_enable() in pm_clk_resume()
Date: Tue, 14 Jan 2014 12:02:41 +0000 [thread overview]
Message-ID: <52D52761.1000303@codethink.co.uk> (raw)
In-Reply-To: <1438385.ppqm7XWTt3@vostro.rjw.lan>
On 13/01/14 19:55, Rafael J. Wysocki wrote:
> On Saturday, January 11, 2014 01:05:39 PM Ben Dooks wrote:
>> @@ -262,8 +263,9 @@ int pm_clk_resume(struct device *dev)
>>
>> list_for_each_entry(ce, &psd->clock_list, node) {
>> if (ce->status < PCE_STATUS_ERROR) {
>> - clk_enable(ce->clk);
>> - ce->status = PCE_STATUS_ENABLED;
>> + ret = clk_enable(ce->clk);
>> + if (ret = 0)
>
> Can you please use if (!ret) here?
>
> And analogously in patch [3/3]?
I will fix and re-send today, thanks.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-01-14 12:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 13:05 [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count Ben Dooks
2014-01-11 13:05 ` Ben Dooks
2014-01-11 13:05 ` [PATCH 2/3] power: clock_ops.c: check return of clk_enable() in pm_clk_resume() Ben Dooks
2014-01-11 13:05 ` Ben Dooks
2014-01-13 19:55 ` Rafael J. Wysocki
2014-01-13 19:55 ` Rafael J. Wysocki
2014-01-14 12:02 ` Ben Dooks [this message]
2014-01-14 12:02 ` Ben Dooks
2014-01-11 13:05 ` [PATCH 3/3] power: clock_ops.c: report clock errors from clk_enable() Ben Dooks
2014-01-11 13:05 ` Ben Dooks
2014-01-12 22:04 ` [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count Laurent Pinchart
2014-01-12 22:04 ` Laurent Pinchart
2014-01-13 6:28 ` Ben Dooks
2014-01-13 8:50 ` Geert Uytterhoeven
2014-01-13 8:50 ` Geert Uytterhoeven
2014-01-13 9:21 ` Ben Dooks
-- strict thread matches above, loose matches on Subject: below --
2014-01-14 12:23 [RESEND] v2: clock_ops.c fixes Ben Dooks
2014-01-14 12:23 ` [PATCH 2/3] power: clock_ops.c: check return of clk_enable() in pm_clk_resume() Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D52761.1000303@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.