All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/12] Device Tree support for the at91sam9261ek
Date: Tue, 14 Jan 2014 17:54:10 +0100	[thread overview]
Message-ID: <52D56BB2.1050301@atmel.com> (raw)
In-Reply-To: <1389270709-32662-1-git-send-email-jjhiblot@traphandler.com>

On 09/01/2014 13:31, Jean-Jacques Hiblot :
> This patch set aims at bringing a basic device tree support for the sam9261.
> It's mostly based on the sam9263 stuff.

Nice! Thanks a lot for stepping up.

One general comment though: I would like to have new AT91 SoC described
in DT integrating mainline with Common Clock Framework implemented.
I feel that it would make sense to directly convert sam9261 to CCF to
avoid the pain of an intermediary DT description that would last only
for a couple of kernel revisions.

> It introduces a new driver for the smc/ebi bus. It's used to configure the EBI
> from the DT. I haven't documented its DT bindings yet. Timings can be provided
> as raw values or nanoseconds.

Thanks a lot for taking this SMC-as-a-driver task: it is very cool to
have it!

I will try to review your patches in the coming days... But Boris
already did a good job at this ;-)

> Change since V1:
> * changed the DT representation to use address translation and separate the
>   timings' configuration from the device properties by adding a "simple-bus"
>   inetrmediate node.
> * moved the smc driver from drivers/bus to drivers/memmory
> * smc driver now accepts timings in nanoseconds as well as raw register values
> * smc driver can clip the timings if they're out of bound and dump them to the
>   console
> * DM9000 timings are now described in nanosecs (for the virtue of example)
> 
> supported features:
> * dbgu
> * nand
> * lcd
> * ethernet
> * leds
> 
> Jean-Jacques
> 
> Jean-Jacques Hiblot (12):
>   at91: dt: Add at91sam9261 dt SoC support
>   at91: dt: sam9261: Basic Device Tree support for the at91sam9261ek
>   at91: dt: sam9261: Added support for the lcd display
>   at91: smc: export sam9_smc_cs_read and sam9_smc_cs_configure.
>   at91: smc: Increased the size of tdf_cycles in struct sam9_smc_config.
>   at91: smc: Adds helper functions to validate and clip the smc timings.
>   at91: dt: smc: Added smc bus driver
>   at91: sam9261: Add a clock definition for the smc
>   at91: dt: sam9261: Pinmux DT entries for the SMC/EBI interface
>   at91: dt: sam9261: Add an entry in the DT for the SMC/EBI bus driver.
>   at91: dt: sam9261: moved the NAND under the smc node
>   at91: dt: sam9261: Added DM9000 in the device tree
> 
>  arch/arm/boot/dts/Makefile                     |   2 +
>  arch/arm/boot/dts/at91sam9261.dtsi             | 639 +++++++++++++++++++++++++
>  arch/arm/boot/dts/at91sam9261ek.dts            | 164 +++++++
>  arch/arm/mach-at91/at91sam9261.c               |  17 +
>  arch/arm/mach-at91/include/mach/at91sam9_smc.h |   6 +-
>  arch/arm/mach-at91/sam9_smc.c                  |  81 +++-
>  drivers/memory/Kconfig                         |  10 +
>  drivers/memory/Makefile                        |   1 +
>  drivers/memory/atmel-smc.c                     | 431 +++++++++++++++++
>  9 files changed, 1348 insertions(+), 3 deletions(-)
>  create mode 100644 arch/arm/boot/dts/at91sam9261.dtsi
>  create mode 100644 arch/arm/boot/dts/at91sam9261ek.dts
>  create mode 100644 drivers/memory/atmel-smc.c
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: <b.brezillon@overkiz.com>, <arnd@arndb.de>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/12] Device Tree support for the at91sam9261ek
Date: Tue, 14 Jan 2014 17:54:10 +0100	[thread overview]
Message-ID: <52D56BB2.1050301@atmel.com> (raw)
In-Reply-To: <1389270709-32662-1-git-send-email-jjhiblot@traphandler.com>

On 09/01/2014 13:31, Jean-Jacques Hiblot :
> This patch set aims at bringing a basic device tree support for the sam9261.
> It's mostly based on the sam9263 stuff.

Nice! Thanks a lot for stepping up.

One general comment though: I would like to have new AT91 SoC described
in DT integrating mainline with Common Clock Framework implemented.
I feel that it would make sense to directly convert sam9261 to CCF to
avoid the pain of an intermediary DT description that would last only
for a couple of kernel revisions.

> It introduces a new driver for the smc/ebi bus. It's used to configure the EBI
> from the DT. I haven't documented its DT bindings yet. Timings can be provided
> as raw values or nanoseconds.

Thanks a lot for taking this SMC-as-a-driver task: it is very cool to
have it!

I will try to review your patches in the coming days... But Boris
already did a good job at this ;-)

> Change since V1:
> * changed the DT representation to use address translation and separate the
>   timings' configuration from the device properties by adding a "simple-bus"
>   inetrmediate node.
> * moved the smc driver from drivers/bus to drivers/memmory
> * smc driver now accepts timings in nanoseconds as well as raw register values
> * smc driver can clip the timings if they're out of bound and dump them to the
>   console
> * DM9000 timings are now described in nanosecs (for the virtue of example)
> 
> supported features:
> * dbgu
> * nand
> * lcd
> * ethernet
> * leds
> 
> Jean-Jacques
> 
> Jean-Jacques Hiblot (12):
>   at91: dt: Add at91sam9261 dt SoC support
>   at91: dt: sam9261: Basic Device Tree support for the at91sam9261ek
>   at91: dt: sam9261: Added support for the lcd display
>   at91: smc: export sam9_smc_cs_read and sam9_smc_cs_configure.
>   at91: smc: Increased the size of tdf_cycles in struct sam9_smc_config.
>   at91: smc: Adds helper functions to validate and clip the smc timings.
>   at91: dt: smc: Added smc bus driver
>   at91: sam9261: Add a clock definition for the smc
>   at91: dt: sam9261: Pinmux DT entries for the SMC/EBI interface
>   at91: dt: sam9261: Add an entry in the DT for the SMC/EBI bus driver.
>   at91: dt: sam9261: moved the NAND under the smc node
>   at91: dt: sam9261: Added DM9000 in the device tree
> 
>  arch/arm/boot/dts/Makefile                     |   2 +
>  arch/arm/boot/dts/at91sam9261.dtsi             | 639 +++++++++++++++++++++++++
>  arch/arm/boot/dts/at91sam9261ek.dts            | 164 +++++++
>  arch/arm/mach-at91/at91sam9261.c               |  17 +
>  arch/arm/mach-at91/include/mach/at91sam9_smc.h |   6 +-
>  arch/arm/mach-at91/sam9_smc.c                  |  81 +++-
>  drivers/memory/Kconfig                         |  10 +
>  drivers/memory/Makefile                        |   1 +
>  drivers/memory/atmel-smc.c                     | 431 +++++++++++++++++
>  9 files changed, 1348 insertions(+), 3 deletions(-)
>  create mode 100644 arch/arm/boot/dts/at91sam9261.dtsi
>  create mode 100644 arch/arm/boot/dts/at91sam9261ek.dts
>  create mode 100644 drivers/memory/atmel-smc.c
> 


-- 
Nicolas Ferre

  parent reply	other threads:[~2014-01-14 16:54 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 12:31 [PATCH v2 00/12] Device Tree support for the at91sam9261ek Jean-Jacques Hiblot
2014-01-09 12:31 ` Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 01/12] at91: dt: Add at91sam9261 dt SoC support Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-14 17:01   ` Nicolas Ferre
2014-01-14 17:01     ` Nicolas Ferre
2014-01-15 10:08     ` Jean-Jacques Hiblot
2014-01-15 10:08       ` Jean-Jacques Hiblot
2014-01-15 10:14       ` Nicolas Ferre
2014-01-15 10:14         ` Nicolas Ferre
2014-01-15 11:31     ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-15 11:31       ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-09 12:31 ` [PATCH v2 02/12] at91: dt: sam9261: Basic Device Tree support for the at91sam9261ek Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-14 17:06   ` Nicolas Ferre
2014-01-14 17:06     ` Nicolas Ferre
2014-01-09 12:31 ` [PATCH v2 03/12] at91: dt: sam9261: Added support for the lcd display Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-09 17:07   ` boris brezillon
2014-01-09 17:07     ` boris brezillon
2014-01-15 11:27     ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-15 11:27       ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-14 17:09   ` Nicolas Ferre
2014-01-14 17:09     ` Nicolas Ferre
2014-01-09 12:31 ` [PATCH v2 04/12] at91: smc: export sam9_smc_cs_read and sam9_smc_cs_configure Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 05/12] at91: smc: Increased the size of tdf_cycles in struct sam9_smc_config Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 06/12] at91: smc: Adds helper functions to validate and clip the smc timings Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-15  9:44   ` Nicolas Ferre
2014-01-15  9:44     ` Nicolas Ferre
2014-01-15  9:54     ` Jean-Jacques Hiblot
2014-01-15  9:54       ` Jean-Jacques Hiblot
2014-01-15 10:18       ` Nicolas Ferre
2014-01-15 10:18         ` Nicolas Ferre
2014-01-09 12:31 ` [PATCH v2 07/12] at91: dt: smc: Added smc bus driver Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-09 16:59   ` boris brezillon
2014-01-09 16:59     ` boris brezillon
2014-01-09 21:04     ` Jean-Jacques Hiblot
2014-01-09 21:04       ` Jean-Jacques Hiblot
2014-01-10 11:01       ` Jean-Jacques Hiblot
2014-01-10 11:01         ` Jean-Jacques Hiblot
2014-01-10 11:08         ` Jean-Jacques Hiblot
2014-01-10 11:08           ` Jean-Jacques Hiblot
2014-01-11  8:06       ` boris brezillon
2014-01-11  8:06         ` boris brezillon
2014-01-14 14:20         ` Jean-Jacques Hiblot
2014-01-14 14:20           ` Jean-Jacques Hiblot
2014-01-14 15:01           ` Nicolas Ferre
2014-01-14 15:01             ` Nicolas Ferre
2014-02-07  8:42   ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-07  8:42     ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-09 12:31 ` [PATCH v2 08/12] at91: sam9261: Add a clock definition for the smc Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 09/12] at91: dt: sam9261: Pinmux DT entries for the SMC/EBI interface Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-15 11:25   ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-15 11:25     ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-09 12:31 ` [PATCH v2 10/12] at91: dt: sam9261: Add an entry in the DT for the SMC/EBI bus driver Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 11/12] at91: dt: sam9261: moved the NAND under the smc node Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-09 12:31 ` [PATCH v2 12/12] at91: dt: sam9261: Added DM9000 in the device tree Jean-Jacques Hiblot
2014-01-09 12:31   ` Jean-Jacques Hiblot
2014-01-15 11:23   ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-15 11:23     ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-14 16:54 ` Nicolas Ferre [this message]
2014-01-14 16:54   ` [PATCH v2 00/12] Device Tree support for the at91sam9261ek Nicolas Ferre
2014-01-15  8:34   ` Jean-Jacques Hiblot
2014-01-15  8:34     ` Jean-Jacques Hiblot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D56BB2.1050301@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.