From: Stefan Weil <sw@weilnetz.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] exec: Exclude non portable function for MinGW
Date: Tue, 14 Jan 2014 18:40:03 +0100 [thread overview]
Message-ID: <52D57673.7020100@weilnetz.de> (raw)
In-Reply-To: <52D57343.8000205@msgid.tls.msk.ru>
Am 14.01.2014 18:26, schrieb Michael Tokarev:
> 14.01.2014 10:00, Stefan Weil wrote:
>> cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are
>> unavailable for MinGW. As the function is unused for MinGW, it can simply
>> be excluded from compilation.
> I applied it to -trivial. But maybe it's better to just move whole thing to kvm-all.c where
> it is actually used?
>
> Thanks,
>
> /mjt
That's a good suggestion.
Juan, a comment in include/exec/ram_addr.h says that those functions
will be removed soon. Would you suggest moving them to kvm-all.c now, or
would you prefer the conditional compilation for MinGW which I
introduced with my patch?
Regards,
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec: Exclude non portable function for MinGW
Date: Tue, 14 Jan 2014 18:40:03 +0100 [thread overview]
Message-ID: <52D57673.7020100@weilnetz.de> (raw)
In-Reply-To: <52D57343.8000205@msgid.tls.msk.ru>
Am 14.01.2014 18:26, schrieb Michael Tokarev:
> 14.01.2014 10:00, Stefan Weil wrote:
>> cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are
>> unavailable for MinGW. As the function is unused for MinGW, it can simply
>> be excluded from compilation.
> I applied it to -trivial. But maybe it's better to just move whole thing to kvm-all.c where
> it is actually used?
>
> Thanks,
>
> /mjt
That's a good suggestion.
Juan, a comment in include/exec/ram_addr.h says that those functions
will be removed soon. Would you suggest moving them to kvm-all.c now, or
would you prefer the conditional compilation for MinGW which I
introduced with my patch?
Regards,
Stefan
next prev parent reply other threads:[~2014-01-14 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 6:00 [Qemu-trivial] [PATCH] exec: Exclude non portable function for MinGW Stefan Weil
2014-01-14 6:00 ` [Qemu-devel] " Stefan Weil
2014-01-14 17:26 ` [Qemu-trivial] " Michael Tokarev
2014-01-14 17:26 ` [Qemu-devel] " Michael Tokarev
2014-01-14 17:40 ` Stefan Weil [this message]
2014-01-14 17:40 ` Stefan Weil
2014-01-14 18:18 ` Juan Quintela
2014-01-14 18:18 ` [Qemu-devel] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D57673.7020100@weilnetz.de \
--to=sw@weilnetz.de \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.