[ath9k-devel] [PATCH 1/5] ath: add common function ath_is_mybeacon

[Antonio Quartulli <antonio@meshcoding.com>]

On 15/01/14 17:07, Oleksij Rempel wrote:
> this function is used by most ath driver, so it can be moved here.
> 
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> ---
>  drivers/net/wireless/ath/ath.h  |  2 ++
>  drivers/net/wireless/ath/main.c | 11 +++++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h
> index e0ba7cd..b59cfbe 100644
> --- a/drivers/net/wireless/ath/ath.h
> +++ b/drivers/net/wireless/ath/ath.h
> @@ -17,6 +17,7 @@
>  #ifndef ATH_H
>  #define ATH_H
>  
> +#include <linux/etherdevice.h>
>  #include <linux/skbuff.h>
>  #include <linux/if_ether.h>
>  #include <linux/spinlock.h>
> @@ -165,6 +166,7 @@ struct ath_common {
>  struct sk_buff *ath_rxbuf_alloc(struct ath_common *common,
>  				u32 len,
>  				gfp_t gfp_mask);
> +bool ath_is_mybeacon(struct ath_common *common, struct ieee80211_hdr *hdr);
>  
>  void ath_hw_setbssidmask(struct ath_common *common);
>  void ath_key_delete(struct ath_common *common, struct ieee80211_key_conf *key);
> diff --git a/drivers/net/wireless/ath/main.c b/drivers/net/wireless/ath/main.c
> index 8e99540..9cb15d9 100644
> --- a/drivers/net/wireless/ath/main.c
> +++ b/drivers/net/wireless/ath/main.c
> @@ -59,6 +59,17 @@ struct sk_buff *ath_rxbuf_alloc(struct ath_common *common,
>  }
>  EXPORT_SYMBOL(ath_rxbuf_alloc);
>  
> +bool ath_is_mybeacon(struct ath_common *common, struct ieee80211_hdr *hdr)
> +{
> +	if (ieee80211_is_beacon(hdr->frame_control) &&
> +			!is_zero_ether_addr(common->curbssid) &&
> +			ether_addr_equal_64bits(hdr->addr3, common->curbssid))
> +		return true;
> +

Apart from the fact that the expression in the if guard is badly
indented, couldn't you just return the value of that expression and
remove the if at all?

Cheers,

> +	return false;
> +}
> +EXPORT_SYMBOL(ath_is_mybeacon);
> +
>  void ath_printk(const char *level, const struct ath_common* common,
>  		const char *fmt, ...)
>  {
> 


-- 
Antonio Quartulli

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20140115/a9b04d4a/attachment-0001.pgp