* [PATCH net-next] sctp: remove the unnecessary assignment
@ 2014-01-16 8:25 ` Wang Weidong
0 siblings, 0 replies; 6+ messages in thread
From: Wang Weidong @ 2014-01-16 8:25 UTC (permalink / raw)
To: Neil Horman, David Miller, Vlad Yasevich; +Cc: netdev, linux-sctp
When go the right path, the status is 0, no need to assign it again.
So just remove the assignment.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
net/sctp/protocol.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 7c16108..d6934dc 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -1461,7 +1461,6 @@ static __init int sctp_init(void)
if (status)
goto err_v6_add_protocol;
- status = 0;
out:
return status;
err_v6_add_protocol:
--
1.7.12
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next] sctp: remove the unnecessary assignment
@ 2014-01-16 8:25 ` Wang Weidong
0 siblings, 0 replies; 6+ messages in thread
From: Wang Weidong @ 2014-01-16 8:25 UTC (permalink / raw)
To: Neil Horman, David Miller, Vlad Yasevich; +Cc: netdev, linux-sctp
When go the right path, the status is 0, no need to assign it again.
So just remove the assignment.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
net/sctp/protocol.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 7c16108..d6934dc 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -1461,7 +1461,6 @@ static __init int sctp_init(void)
if (status)
goto err_v6_add_protocol;
- status = 0;
out:
return status;
err_v6_add_protocol:
--
1.7.12
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] sctp: remove the unnecessary assignment
2014-01-16 8:25 ` Wang Weidong
@ 2014-01-16 12:18 ` Neil Horman
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Horman @ 2014-01-16 12:18 UTC (permalink / raw)
To: Wang Weidong; +Cc: David Miller, Vlad Yasevich, netdev, linux-sctp
On Thu, Jan 16, 2014 at 04:25:19PM +0800, Wang Weidong wrote:
> When go the right path, the status is 0, no need to assign it again.
> So just remove the assignment.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> ---
> net/sctp/protocol.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
> index 7c16108..d6934dc 100644
> --- a/net/sctp/protocol.c
> +++ b/net/sctp/protocol.c
> @@ -1461,7 +1461,6 @@ static __init int sctp_init(void)
> if (status)
> goto err_v6_add_protocol;
>
> - status = 0;
> out:
> return status;
> err_v6_add_protocol:
> --
> 1.7.12
>
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] sctp: remove the unnecessary assignment
@ 2014-01-16 12:18 ` Neil Horman
0 siblings, 0 replies; 6+ messages in thread
From: Neil Horman @ 2014-01-16 12:18 UTC (permalink / raw)
To: Wang Weidong; +Cc: David Miller, Vlad Yasevich, netdev, linux-sctp
On Thu, Jan 16, 2014 at 04:25:19PM +0800, Wang Weidong wrote:
> When go the right path, the status is 0, no need to assign it again.
> So just remove the assignment.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
> ---
> net/sctp/protocol.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
> index 7c16108..d6934dc 100644
> --- a/net/sctp/protocol.c
> +++ b/net/sctp/protocol.c
> @@ -1461,7 +1461,6 @@ static __init int sctp_init(void)
> if (status)
> goto err_v6_add_protocol;
>
> - status = 0;
> out:
> return status;
> err_v6_add_protocol:
> --
> 1.7.12
>
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] sctp: remove the unnecessary assignment
2014-01-16 8:25 ` Wang Weidong
@ 2014-01-17 1:37 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2014-01-17 1:37 UTC (permalink / raw)
To: wangweidong1; +Cc: nhorman, vyasevich, netdev, linux-sctp
From: Wang Weidong <wangweidong1@huawei.com>
Date: Thu, 16 Jan 2014 16:25:19 +0800
> When go the right path, the status is 0, no need to assign it again.
> So just remove the assignment.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] sctp: remove the unnecessary assignment
@ 2014-01-17 1:37 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2014-01-17 1:37 UTC (permalink / raw)
To: wangweidong1; +Cc: nhorman, vyasevich, netdev, linux-sctp
From: Wang Weidong <wangweidong1@huawei.com>
Date: Thu, 16 Jan 2014 16:25:19 +0800
> When go the right path, the status is 0, no need to assign it again.
> So just remove the assignment.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-17 1:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-16 8:25 [PATCH net-next] sctp: remove the unnecessary assignment Wang Weidong
2014-01-16 8:25 ` Wang Weidong
2014-01-16 12:18 ` Neil Horman
2014-01-16 12:18 ` Neil Horman
2014-01-17 1:37 ` David Miller
2014-01-17 1:37 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.