From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 net-next 1/4] sh_eth: Use bool as return type of sh_eth_is_gether()
Date: Thu, 16 Jan 2014 15:19:46 +0000 [thread overview]
Message-ID: <52D7F892.1050708@cogentembedded.com> (raw)
In-Reply-To: <1389839656-10932-2-git-send-email-horms+renesas@verge.net.au>
Hello.
On 16-01-2014 6:34, Simon Horman wrote:
> Return a boolean and use true and false.
You're not using them explicitly anymore. I'd update the changelog
with converting the function to one-liner.
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 net-next 1/4] sh_eth: Use bool as return type of sh_eth_is_gether()
Date: Thu, 16 Jan 2014 19:19:46 +0400 [thread overview]
Message-ID: <52D7F892.1050708@cogentembedded.com> (raw)
In-Reply-To: <1389839656-10932-2-git-send-email-horms+renesas@verge.net.au>
Hello.
On 16-01-2014 6:34, Simon Horman wrote:
> Return a boolean and use true and false.
You're not using them explicitly anymore. I'd update the changelog
with converting the function to one-liner.
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-sh@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Magnus Damm <magnus.damm@gmail.com>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH v6 net-next 1/4] sh_eth: Use bool as return type of sh_eth_is_gether()
Date: Thu, 16 Jan 2014 19:19:46 +0400 [thread overview]
Message-ID: <52D7F892.1050708@cogentembedded.com> (raw)
In-Reply-To: <1389839656-10932-2-git-send-email-horms+renesas@verge.net.au>
Hello.
On 16-01-2014 6:34, Simon Horman wrote:
> Return a boolean and use true and false.
You're not using them explicitly anymore. I'd update the changelog
with converting the function to one-liner.
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
WBR, Sergei
next prev parent reply other threads:[~2014-01-16 15:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 2:34 [PATCH v6 0/4] Add ethernet support for r7s72100 Simon Horman
2014-01-16 2:34 ` Simon Horman
2014-01-16 2:34 ` Simon Horman
2014-01-16 2:34 ` [PATCH v6 net-next 1/4] sh_eth: Use bool as return type of sh_eth_is_gether() Simon Horman
2014-01-16 2:34 ` Simon Horman
2014-01-16 2:34 ` Simon Horman
2014-01-16 15:19 ` Sergei Shtylyov [this message]
2014-01-16 15:19 ` Sergei Shtylyov
2014-01-16 15:19 ` Sergei Shtylyov
2014-01-16 2:34 ` [PATCH v6 net-next 2/4] sh_eth: Add support for r7s72100 Simon Horman
2014-01-16 2:34 ` Simon Horman
2014-01-16 2:34 ` Simon Horman
2014-01-16 2:34 ` [PATCH v6 3/4] ARM: shmobile: r7s72100: Add clock for r7s72100-ether Simon Horman
2014-01-16 2:34 ` Simon Horman
2014-01-16 2:34 ` Simon Horman
2014-01-16 2:34 ` [PATCH v6 4/4] ARM: shmobile: genmai: Enable r7s72100-ether Simon Horman
2014-01-16 2:34 ` Simon Horman
2014-01-16 2:34 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D7F892.1050708@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.