All of lore.kernel.org
 help / color / mirror / Atom feed
* 2 bugs (errno = EINTR) in v4l2grab.c and v4l2gl.c?
@ 2014-01-16 17:45 Andreas Weber
  0 siblings, 0 replies; only message in thread
From: Andreas Weber @ 2014-01-16 17:45 UTC (permalink / raw)
  To: linux-media

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

Dear maintainers,

I guess these are 2 bugs:
contrib/test/v4l2grab.c:132: } while ((r == -1 && (errno = EINTR)));
contrib/test/v4l2gl.c:227:   } while ((r == -1 && (errno = EINTR)));

please consider my attached patch if it's really a bug.
Regards, Andy

[-- Attachment #2: errno_assignment.patch --]
[-- Type: text/x-diff, Size: 1269 bytes --]

>From 63d4fd18cb91852b64c81bf63d0d4100fc53d38d Mon Sep 17 00:00:00 2001
From: Andreas Weber <andreas.weber@hs-offenburg.de>
Date: Thu, 16 Jan 2014 18:43:31 +0100
Subject: [PATCH] bugfix for errno assignment in while loop

---
 contrib/test/v4l2gl.c   |    2 +-
 contrib/test/v4l2grab.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/test/v4l2gl.c b/contrib/test/v4l2gl.c
index e921212..4b549c1 100644
--- a/contrib/test/v4l2gl.c
+++ b/contrib/test/v4l2gl.c
@@ -224,7 +224,7 @@ static int capture(char *dev_name, int x_res, int y_res, int n_frames,
 			tv.tv_usec = 0;
 
 			r = select(fd + 1, &fds, NULL, NULL, &tv);
-		} while ((r == -1 && (errno = EINTR)));
+		} while ((r == -1 && (errno == EINTR)));
 		if (r == -1) {
 			perror("select");
 			return errno;
diff --git a/contrib/test/v4l2grab.c b/contrib/test/v4l2grab.c
index a93ad43..14d2a8f 100644
--- a/contrib/test/v4l2grab.c
+++ b/contrib/test/v4l2grab.c
@@ -129,7 +129,7 @@ static int capture(char *dev_name, int x_res, int y_res, int n_frames,
 			tv.tv_usec = 0;
 
 			r = select(fd + 1, &fds, NULL, NULL, &tv);
-		} while ((r == -1 && (errno = EINTR)));
+		} while ((r == -1 && (errno == EINTR)));
 		if (r == -1) {
 			perror("select");
 			return errno;
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-01-16 17:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-16 17:45 2 bugs (errno = EINTR) in v4l2grab.c and v4l2gl.c? Andreas Weber

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.