From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] cmd_pxe.c add any option for filesystem with sysboot uses generic load
Date: Thu, 16 Jan 2014 13:03:03 -0700 [thread overview]
Message-ID: <52D83AF7.3010405@wwwdotorg.org> (raw)
In-Reply-To: <1387264612-17834-2-git-send-email-dennis@ausil.us>
On 12/17/2013 12:16 AM, Dennis Gilmore wrote:
> Signed-off-by: Dennis Gilmore <dennis@ausil.us>
Nit pick: A patch description might be useful.
> @@ -1539,6 +1553,8 @@ int do_sysboot(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> do_getfile = do_get_ext2;
> else if (strstr(argv[3], "fat"))
> do_getfile = do_get_fat;
> + else if (strstr(argv[3], "any"))
> + do_getfile = do_get_any;
This is a total bikeshed, so feel free to ignore it cmopletely:
Is "any" the best choice here? In other U-Boot commands, "-" is used to
mean something similar, so perhaps "-" would work better here? Still, I
guess "-" usually means "none" or "missing" more than "any", so perhaps
"any" is better after all. Anyway, just a point for thought; I'm fine
either way.
next prev parent reply other threads:[~2014-01-16 20:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 7:16 [U-Boot] [RFC v2] implementation of generic distro configs Dennis Gilmore
2013-12-17 7:16 ` [U-Boot] [PATCH 1/6] cmd_pxe.c add any option for filesystem with sysboot uses generic load Dennis Gilmore
2014-01-16 20:03 ` Stephen Warren [this message]
2013-12-17 7:16 ` [U-Boot] [PATCH 2/6] add a generic set of configs to enable Distros to more easier support u-boot based systems Dennis Gilmore
2014-01-16 20:05 ` Stephen Warren
2014-01-16 20:17 ` Stephen Warren
2014-01-16 20:43 ` Stephen Warren
2013-12-17 7:16 ` [U-Boot] [PATCH 3/6] port andboard to use generic distro config Dennis Gilmore
2013-12-17 7:16 ` [U-Boot] [PATCH 4/6] port am335x_evm to use generic distro configs Dennis Gilmore
2013-12-17 7:16 ` [U-Boot] [PATCH 5/6] port beagleboard " Dennis Gilmore
2013-12-17 7:16 ` [U-Boot] [PATCH 6/6] port omap4 boards " Dennis Gilmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D83AF7.3010405@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.